Issue 83753006: Merge 236478 "Update accept_return_character_ for synthetic even..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 83753006: Merge 236478 "Update accept_return_character_ for synthetic even..." (Closed)

Created:
7 years, 1 month ago by msw

Modified:
7 years, 1 month ago

Reviewers:
msw

CC:
chromium-reviews, joi+watch-content_chromium.org, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, jam, penghuang+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, James Su, miu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/1700/src/

Visibility:
Public.

More Reviews

Description

Merge 236478 "Update accept_return_character_ for synthetic even..." > Update accept_return_character_ for synthetic events too. > > Tweak RenderWidgetHostViewAura RETURN key forwarding. > This is a followup fix for http://crrev.com/235194 > That prevented forwarding CTRL+M as RETURN for Issue 315547. > > This fixes RETURN handling for Win8 Metro Viewer processes. > Metro Viewer's synthetic events should be treated similarly. > > BUG=321656, 315547 > TEST=Win8 Metro Ash Chrome RETURN key should submit web forms. > TBR=nona@chromium.org,jochen@chromium.org > > Review URL: https://codereview.chromium.org/79843002 TBR=msw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236934

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	content/browser/renderer_host/render_widget_host_view_aura.cc	View		2 chunks	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r236934.

Expand Messages | Collapse Messages