Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 79843002: Update accept_return_character_ for synthetic events too. (Closed)

Created:
7 years, 1 month ago by msw
Modified:
7 years, 1 month ago
CC:
chromium-reviews, joi+watch-content_chromium.org, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, jam, penghuang+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, James Su, miu+watch_chromium.org, Ben Goodger (Google)
Visibility:
Public.

Description

Update accept_return_character_ for synthetic events too. Tweak RenderWidgetHostViewAura RETURN key forwarding. This is a followup fix for http://crrev.com/235194 That prevented forwarding CTRL+M as RETURN for Issue 315547. This fixes RETURN handling for Win8 Metro Viewer processes. Metro Viewer's synthetic events should be treated similarly. BUG=321656, 315547 TEST=Win8 Metro Ash Chrome RETURN key should submit web forms. TBR=nona@chromium.org,jochen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236478

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M content/browser/renderer_host/render_widget_host_view_aura.cc View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
msw
Hey Jochen and Nona, please take a look asap, thanks!
7 years, 1 month ago (2013-11-20 23:42:44 UTC) #1
msw
Actually, I'm going to TBR this and put it in the CQ. Hopefully we'll make ...
7 years, 1 month ago (2013-11-20 23:52:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/79843002/1
7 years, 1 month ago (2013-11-21 00:24:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/79843002/1
7 years, 1 month ago (2013-11-21 02:19:12 UTC) #4
Seigo Nonaka
lgtm
7 years, 1 month ago (2013-11-21 05:00:31 UTC) #5
commit-bot: I haz the power
7 years, 1 month ago (2013-11-21 09:25:22 UTC) #6
Message was sent while issue was closed.
Change committed as 236478

Powered by Google App Engine
This is Rietveld 408576698