Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 837503003: Check author of a CL agaist the AUTHORS file. (Closed)

Created:
5 years, 11 months ago by marja
Modified:
5 years, 11 months ago
Reviewers:
Michael Achenbach
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Check author of a CL against the AUTHORS file. The code is copied from Chromium presubmit. BUG= Committed: https://crrev.com/770d866823dd9240e2adfd93a3abca447bc14297 Cr-Commit-Position: refs/heads/master@{#26077}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -0 lines) Patch
M PRESUBMIT.py View 2 chunks +2 lines, -0 lines 0 comments Download
M tools/presubmit.py View 1 chunk +27 lines, -0 lines 2 comments Download

Messages

Total messages: 7 (2 generated)
Michael Achenbach
lgtm https://codereview.chromium.org/837503003/diff/1/tools/presubmit.py File tools/presubmit.py (right): https://codereview.chromium.org/837503003/diff/1/tools/presubmit.py#newcode460 tools/presubmit.py:460: return [output_api.PresubmitPromptWarning( I assume a warning is enough ...
5 years, 11 months ago (2015-01-15 12:29:22 UTC) #2
marja
thanks for review https://codereview.chromium.org/837503003/diff/1/tools/presubmit.py File tools/presubmit.py (right): https://codereview.chromium.org/837503003/diff/1/tools/presubmit.py#newcode460 tools/presubmit.py:460: return [output_api.PresubmitPromptWarning( On 2015/01/15 12:29:22, Michael ...
5 years, 11 months ago (2015-01-15 12:37:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/837503003/1
5 years, 11 months ago (2015-01-15 12:42:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-15 13:10:06 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-15 13:10:18 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/770d866823dd9240e2adfd93a3abca447bc14297
Cr-Commit-Position: refs/heads/master@{#26077}

Powered by Google App Engine
This is Rietveld 408576698