OLD | NEW |
1 # Copyright 2012 the V8 project authors. All rights reserved. | 1 # Copyright 2012 the V8 project authors. All rights reserved. |
2 # Redistribution and use in source and binary forms, with or without | 2 # Redistribution and use in source and binary forms, with or without |
3 # modification, are permitted provided that the following conditions are | 3 # modification, are permitted provided that the following conditions are |
4 # met: | 4 # met: |
5 # | 5 # |
6 # * Redistributions of source code must retain the above copyright | 6 # * Redistributions of source code must retain the above copyright |
7 # notice, this list of conditions and the following disclaimer. | 7 # notice, this list of conditions and the following disclaimer. |
8 # * Redistributions in binary form must reproduce the above | 8 # * Redistributions in binary form must reproduce the above |
9 # copyright notice, this list of conditions and the following | 9 # copyright notice, this list of conditions and the following |
10 # disclaimer in the documentation and/or other materials provided | 10 # disclaimer in the documentation and/or other materials provided |
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
62 | 62 |
63 def _V8PresubmitChecks(input_api, output_api): | 63 def _V8PresubmitChecks(input_api, output_api): |
64 """Runs the V8 presubmit checks.""" | 64 """Runs the V8 presubmit checks.""" |
65 import sys | 65 import sys |
66 sys.path.append(input_api.os_path.join( | 66 sys.path.append(input_api.os_path.join( |
67 input_api.PresubmitLocalPath(), 'tools')) | 67 input_api.PresubmitLocalPath(), 'tools')) |
68 from presubmit import CppLintProcessor | 68 from presubmit import CppLintProcessor |
69 from presubmit import SourceProcessor | 69 from presubmit import SourceProcessor |
70 from presubmit import CheckRuntimeVsNativesNameClashes | 70 from presubmit import CheckRuntimeVsNativesNameClashes |
71 from presubmit import CheckExternalReferenceRegistration | 71 from presubmit import CheckExternalReferenceRegistration |
| 72 from presubmit import CheckAuthorizedAuthor |
72 | 73 |
73 results = [] | 74 results = [] |
74 if not CppLintProcessor().Run(input_api.PresubmitLocalPath()): | 75 if not CppLintProcessor().Run(input_api.PresubmitLocalPath()): |
75 results.append(output_api.PresubmitError("C++ lint check failed")) | 76 results.append(output_api.PresubmitError("C++ lint check failed")) |
76 if not SourceProcessor().Run(input_api.PresubmitLocalPath()): | 77 if not SourceProcessor().Run(input_api.PresubmitLocalPath()): |
77 results.append(output_api.PresubmitError( | 78 results.append(output_api.PresubmitError( |
78 "Copyright header, trailing whitespaces and two empty lines " \ | 79 "Copyright header, trailing whitespaces and two empty lines " \ |
79 "between declarations check failed")) | 80 "between declarations check failed")) |
80 if not CheckRuntimeVsNativesNameClashes(input_api.PresubmitLocalPath()): | 81 if not CheckRuntimeVsNativesNameClashes(input_api.PresubmitLocalPath()): |
81 results.append(output_api.PresubmitError( | 82 results.append(output_api.PresubmitError( |
82 "Runtime/natives name clash check failed")) | 83 "Runtime/natives name clash check failed")) |
83 if not CheckExternalReferenceRegistration(input_api.PresubmitLocalPath()): | 84 if not CheckExternalReferenceRegistration(input_api.PresubmitLocalPath()): |
84 results.append(output_api.PresubmitError( | 85 results.append(output_api.PresubmitError( |
85 "External references registration check failed")) | 86 "External references registration check failed")) |
| 87 results.extend(CheckAuthorizedAuthor(input_api, output_api)) |
86 return results | 88 return results |
87 | 89 |
88 | 90 |
89 def _CheckUnwantedDependencies(input_api, output_api): | 91 def _CheckUnwantedDependencies(input_api, output_api): |
90 """Runs checkdeps on #include statements added in this | 92 """Runs checkdeps on #include statements added in this |
91 change. Breaking - rules is an error, breaking ! rules is a | 93 change. Breaking - rules is an error, breaking ! rules is a |
92 warning. | 94 warning. |
93 """ | 95 """ |
94 # We need to wait until we have an input_api object and use this | 96 # We need to wait until we have an input_api object and use this |
95 # roundabout construct to import checkdeps because this file is | 97 # roundabout construct to import checkdeps because this file is |
(...skipping 151 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
247 'v8_linux64_rel': set(['defaulttests']), | 249 'v8_linux64_rel': set(['defaulttests']), |
248 'v8_linux_arm_dbg': set(['defaulttests']), | 250 'v8_linux_arm_dbg': set(['defaulttests']), |
249 'v8_linux_arm64_rel': set(['defaulttests']), | 251 'v8_linux_arm64_rel': set(['defaulttests']), |
250 'v8_linux_layout_dbg': set(['defaulttests']), | 252 'v8_linux_layout_dbg': set(['defaulttests']), |
251 'v8_linux_chromium_gn_rel': set(['defaulttests']), | 253 'v8_linux_chromium_gn_rel': set(['defaulttests']), |
252 'v8_mac_rel': set(['defaulttests']), | 254 'v8_mac_rel': set(['defaulttests']), |
253 'v8_win_rel': set(['defaulttests']), | 255 'v8_win_rel': set(['defaulttests']), |
254 'v8_win64_compile_rel': set(['defaulttests']), | 256 'v8_win64_compile_rel': set(['defaulttests']), |
255 }, | 257 }, |
256 } | 258 } |
OLD | NEW |