Issue 83733005: Add support for 32-bit and 64-bit Windows compiles in GN.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 83733005: Add support for 32-bit and 64-bit Windows compiles in GN. (Closed)

Created:
7 years, 1 month ago by brettw

Modified:
7 years, 1 month ago

Reviewers:
scottmg

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Add support for 32-bit and 64-bit Windows compiles in GN. Rename ia32 and ia64 to x86 and x64 BUG=297677, 322109 R=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236851

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+161 lines, -104 lines)			Patch
M	build/config/BUILDCONFIG.gn	View	1	3 chunks	+21 lines, -5 lines	0 comments	Download
M	build/config/compiler/BUILD.gn	View		1 chunk	+1 line, -1 line	0 comments	Download
M	build/config/win/BUILD.gn	View		1 chunk	+1 line, -4 lines	0 comments	Download
M	build/toolchain/win/BUILD.gn	View		4 chunks	+75 lines, -82 lines	0 comments	Download
M	build/toolchain/win/setup_toolchain.py	View		2 chunks	+53 lines, -2 lines	0 comments	Download
M	tools/gn/args.cc	View	1	4 chunks	+8 lines, -8 lines	0 comments	Download
M	tools/gn/variables.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

brettw

7 years, 1 month ago (2013-11-22 22:39:41 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r236851 (presubmit successful).