Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Unified Diff: tools/gn/args.cc

Issue 83733005: Add support for 32-bit and 64-bit Windows compiles in GN. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/toolchain/win/setup_toolchain.py ('k') | tools/gn/variables.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/args.cc
diff --git a/tools/gn/args.cc b/tools/gn/args.cc
index 2d9aa6e81d0cc670a8a79dd14ffae49c33f83eea..04ced9f6f7331453f326f9d4a54dd51eb038905f 100644
--- a/tools/gn/args.cc
+++ b/tools/gn/args.cc
@@ -179,8 +179,8 @@ void Args::SetSystemVars(Scope* dest) const {
dest->SetValue(variables::kOs, os_val, NULL);
// Host architecture.
- static const char kIa32[] = "ia32";
- static const char kIa64[] = "ia64";
+ static const char kX86[] = "x86";
+ static const char kX64[] = "x64";
const char* arch = NULL;
#if defined(OS_WIN)
// ...on Windows, set the CPU architecture based on the underlying OS, not
@@ -188,10 +188,10 @@ void Args::SetSystemVars(Scope* dest) const {
const base::win::OSInfo* os_info = base::win::OSInfo::GetInstance();
switch (os_info->architecture()) {
case base::win::OSInfo::X86_ARCHITECTURE:
- arch = kIa32;
+ arch = kX86;
break;
case base::win::OSInfo::X64_ARCHITECTURE:
- arch = kIa64;
+ arch = kX64;
break;
default:
CHECK(false) << "Windows architecture not handled.";
@@ -201,9 +201,9 @@ void Args::SetSystemVars(Scope* dest) const {
// ...on all other platforms, just use the bit-tedness of the current
// process.
#if defined(ARCH_CPU_X86_64)
- arch = kIa64;
+ arch = kX64;
#elif defined(ARCH_CPU_X86)
- arch = kIa32;
+ arch = kX86;
#elif defined(ARCH_CPU_ARMEL)
static const char kArm[] = "arm";
arch = kArm;
@@ -212,8 +212,8 @@ void Args::SetSystemVars(Scope* dest) const {
#endif
#endif
// Avoid unused var warning.
- (void)kIa32;
- (void)kIa64;
+ (void)kX86;
+ (void)kX64;
Value arch_val(NULL, std::string(arch));
dest->SetValue(variables::kBuildCpuArch, arch_val, NULL);
« no previous file with comments | « build/toolchain/win/setup_toolchain.py ('k') | tools/gn/variables.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698