Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(42)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: codereview.settings
Issue
837193005
:
pkg/shelf: formatted code (Closed)
Base URL: https://github.com/dart-lang/shelf.git@master
Patch Set: nits
Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
codereview.settings
example/example_server.dart
lib/shelf_io.dart
lib/src/cascade.dart
lib/src/handlers/logger.dart
lib/src/hijack_exception.dart
lib/src/message.dart
lib/src/middleware.dart
lib/src/request.dart
lib/src/response.dart
lib/src/shelf_unmodifiable_map.dart
lib/src/util.dart
pubspec.yaml
test/cascade_test.dart
test/create_middleware_test.dart
test/hijack_test.dart
test/message_change_test.dart
test/message_test.dart
test/pipeline_test.dart
test/request_test.dart
test/response_test.dart
test/shelf_io_test.dart
test/test_util.dart
View unified diff
|
Download patch
« no previous file with comments
|
« no previous file
|
example/example_server.dart »
('j') |
lib/src/request.dart »
('J')
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
1
CODE_REVIEW_SERVER:
http
://codereview.chromium.org/
1
CODE_REVIEW_SERVER:
https
://codereview.chromium.org/
2
VIEW_VC: https://github.com/dart-lang/
glob
/commit/
2
VIEW_VC: https://github.com/dart-lang/
shelf
/commit/
3 CC_LIST: reviews@dartlang.org
3 CC_LIST: reviews@dartlang.org
OLD
NEW
« no previous file with comments
|
« no previous file
|
example/example_server.dart »
('j') |
lib/src/request.dart »
('J')
Issue 837193005: pkg/shelf: formatted code (Closed)
Created 5 years, 11 months ago by kevmoo
Modified 5 years, 11 months ago
Reviewers: nweiz
Base URL: https://github.com/dart-lang/shelf.git@master
Comments: 4
This is Rietveld
408576698