Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 837193005: pkg/shelf: formatted code (Closed)

Created:
5 years, 11 months ago by kevmoo
Modified:
5 years, 11 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/shelf.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

pkg/shelf: formatted code also fixed codereview settings R=nweiz@google.com Committed: https://github.com/dart-lang/shelf/commit/a96e7ccfd05a82d00c3169c0854a5f53eb229a18

Patch Set 1 #

Total comments: 2

Patch Set 2 : nits #

Total comments: 2

Patch Set 3 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+184 lines, -190 lines) Patch
M codereview.settings View 1 chunk +2 lines, -2 lines 0 comments Download
M example/example_server.dart View 1 chunk +2 lines, -1 line 0 comments Download
M lib/shelf_io.dart View 5 chunks +15 lines, -13 lines 0 comments Download
M lib/src/cascade.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M lib/src/handlers/logger.dart View 1 chunk +6 lines, -9 lines 0 comments Download
M lib/src/hijack_exception.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/message.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M lib/src/middleware.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M lib/src/request.dart View 1 2 4 chunks +20 lines, -12 lines 0 comments Download
M lib/src/response.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M lib/src/shelf_unmodifiable_map.dart View 1 2 chunks +3 lines, -3 lines 0 comments Download
M lib/src/util.dart View 1 1 chunk +1 line, -2 lines 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M test/cascade_test.dart View 3 chunks +5 lines, -5 lines 0 comments Download
M test/create_middleware_test.dart View 1 11 chunks +38 lines, -37 lines 0 comments Download
M test/hijack_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M test/message_change_test.dart View 2 chunks +13 lines, -14 lines 0 comments Download
M test/message_test.dart View 5 chunks +15 lines, -20 lines 0 comments Download
M test/pipeline_test.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M test/request_test.dart View 1 7 chunks +16 lines, -20 lines 0 comments Download
M test/response_test.dart View 1 7 chunks +14 lines, -10 lines 0 comments Download
M test/shelf_io_test.dart View 1 6 chunks +15 lines, -21 lines 0 comments Download
M test/test_util.dart View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
kevmoo
5 years, 11 months ago (2015-01-08 00:58:01 UTC) #2
nweiz
Bob just released a new version of the formatter; can you re-run it? https://codereview.chromium.org/837193005/diff/1/CHANGELOG.md File ...
5 years, 11 months ago (2015-01-13 00:35:15 UTC) #3
kevmoo
PTAL https://codereview.chromium.org/837193005/diff/1/CHANGELOG.md File CHANGELOG.md (right): https://codereview.chromium.org/837193005/diff/1/CHANGELOG.md#newcode1 CHANGELOG.md:1: ## 0.5.7 On 2015/01/13 00:35:15, nweiz wrote: > ...
5 years, 11 months ago (2015-01-17 21:55:49 UTC) #4
nweiz
lgtm https://codereview.chromium.org/837193005/diff/20001/lib/src/request.dart File lib/src/request.dart (right): https://codereview.chromium.org/837193005/diff/20001/lib/src/request.dart#newcode122 lib/src/request.dart:122: OnHijackCallback onHijack}) : this._(method, requestedUri, Putting ": this()" ...
5 years, 11 months ago (2015-01-20 23:20:31 UTC) #5
kevmoo
https://codereview.chromium.org/837193005/diff/20001/lib/src/request.dart File lib/src/request.dart (right): https://codereview.chromium.org/837193005/diff/20001/lib/src/request.dart#newcode122 lib/src/request.dart:122: OnHijackCallback onHijack}) : this._(method, requestedUri, On 2015/01/20 23:20:31, nweiz ...
5 years, 11 months ago (2015-01-21 00:50:18 UTC) #6
kevmoo
5 years, 11 months ago (2015-01-21 00:51:12 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
a96e7ccfd05a82d00c3169c0854a5f53eb229a18 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698