Add a helper function and update test results with ax role of table header.

Add a helper function, ,IsCellOrTableHeaderRole(), for ax table header
and update test results with the ax role of the table header.
The ax role for table header was updated with blink cl,
crrev.com/816423003.
This patch updates test results according to ax role from it.

BUG=435081
Committed: https://crrev.com/ff9c8d3025f375069298ae71407a31b6f58ee3dd
Cr-Commit-Position: refs/heads/master@{#311035}

[je_julie(Not used), 2015-01-08 02:37:58]

je_julie.kim@samsung.com changed reviewers:
+ dmazzoni@chromium.org

[je_julie(Not used), 2015-01-08 02:37:59]

Hi Dominic,
This patch enables test cases disabled due to update ax role for table header at
crrev.com/816423003.
I didn't enable caption TC because I saw the patch for caption is ongoing with
crrev.com/825633002.

The failure from android_rel_tests_recipe was not related to this patch.
If we look into
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_rel_tes...,
that bot has continuous failure with telemetry_unittests.

PTAL.

[je_julie(Not used), 2015-01-08 04:12:58]

On 2015/01/08 02:37:59, je_julie wrote:
> Hi Dominic,
> This patch enables test cases disabled due to update ax role for table header
at
> crrev.com/816423003.
> I didn't enable caption TC because I saw the patch for caption is ongoing with
> crrev.com/825633002.
> 
> The failure from android_rel_tests_recipe was not related to this patch.
> If we look into
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_rel_tes...,
> that bot has continuous failure with telemetry_unittests.
> 
> PTAL.

Dominic, I found several failure not related to this patch. It seems flaky now.
I'll ask review with new set.

[je_julie(Not used), 2015-01-08 07:10:24]

On 2015/01/08 04:12:58, je_julie wrote:
> On 2015/01/08 02:37:59, je_julie wrote:
> > Hi Dominic,
> > This patch enables test cases disabled due to update ax role for table
header
> at
> > crrev.com/816423003.
> > I didn't enable caption TC because I saw the patch for caption is ongoing
with
> > crrev.com/825633002.
> > 
> > The failure from android_rel_tests_recipe was not related to this patch.
> > If we look into
> >
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_rel_tes...,
> > that bot has continuous failure with telemetry_unittests.
> > 
> > PTAL.
> 
> Dominic, I found several failure not related to this patch. It seems flaky
now.
> I'll ask review with new set.

I've tried to run trybot again and it's updated with green now.
PTAL.

[dmazzoni, 2015-01-08 18:11:25]

lgtm

Thanks! Just one suggestion

https://codereview.chromium.org/837183002/diff/20001/content/browser/accessib...
File content/browser/accessibility/browser_accessibility_cocoa.mm (right):

https://codereview.chromium.org/837183002/diff/20001/content/browser/accessib...
content/browser/accessibility/browser_accessibility_cocoa.mm:236: if ([self
internalRole] != ui::AX_ROLE_CELL &&
Please add a helper function for this, like IsCellOrTableHeaderRole()

https://codereview.chromium.org/837183002/diff/20001/content/browser/accessib...
File content/browser/accessibility/browser_accessibility_win.cc (right):

https://codereview.chromium.org/837183002/diff/20001/content/browser/accessib...
content/browser/accessibility/browser_accessibility_win.cc:2967: ia_role_ ==
ROLE_SYSTEM_COLUMNHEADER) {
Same here - it sounds like the helper should be in BrowserAccessibility so we
can use it on all platforms

[je_julie(Not used), 2015-01-09 15:51:38]

Patchset #3 (id:40001) has been deleted

[je_julie(Not used), 2015-01-09 16:47:37]

Thanks for your suggestion.
I updated patch. PTAL.

https://codereview.chromium.org/837183002/diff/20001/content/browser/accessib...
File content/browser/accessibility/browser_accessibility_cocoa.mm (right):

https://codereview.chromium.org/837183002/diff/20001/content/browser/accessib...
content/browser/accessibility/browser_accessibility_cocoa.mm:236: if ([self
internalRole] != ui::AX_ROLE_CELL &&
On 2015/01/08 18:11:25, dmazzoni wrote:
> Please add a helper function for this, like IsCellOrTableHeaderRole()

Done

https://codereview.chromium.org/837183002/diff/20001/content/browser/accessib...
File content/browser/accessibility/browser_accessibility_win.cc (right):

https://codereview.chromium.org/837183002/diff/20001/content/browser/accessib...
content/browser/accessibility/browser_accessibility_win.cc:2967: ia_role_ ==
ROLE_SYSTEM_COLUMNHEADER) {
On 2015/01/08 18:11:25, dmazzoni wrote:
> Same here - it sounds like the helper should be in BrowserAccessibility so we
> can use it on all platforms

Done.

[dmazzoni, 2015-01-12 07:36:03]

The CQ bit was checked by dmazzoni@chromium.org

[dmazzoni, 2015-01-12 07:36:03]

lgtm

[commit-bot: I haz the power, 2015-01-12 07:36:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/837183002/60001

[commit-bot: I haz the power, 2015-01-12 08:41:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-12 08:41:49]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[je_julie(Not used), 2015-01-12 10:25:30]

The CQ bit was checked by je_julie.kim@samsung.com

[commit-bot: I haz the power, 2015-01-12 10:28:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/837183002/60001

[commit-bot: I haz the power, 2015-01-12 11:15:15]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2015-01-12 11:16:05]

Patchset 3 (id:??) landed as
https://crrev.com/ff9c8d3025f375069298ae71407a31b6f58ee3dd
Cr-Commit-Position: refs/heads/master@{#311035}