content/browser/accessibility/browser_accessibility.cc - Issue 837183002: Add a helper function and update test results with ax role of table header.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/browser_accessibility.cc

Issue 837183002: Add a helper function and update test results with ax role of table header. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add a helper function for ax table header Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/accessibility/browser_accessibility.h ('k') | content/browser/accessibility/browser_accessibility_cocoa.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/accessibility/browser_accessibility.cc

diff --git a/content/browser/accessibility/browser_accessibility.cc b/content/browser/accessibility/browser_accessibility.cc

index 2141fe3f982a5e6cc1a9fdf1ac5710e735524ab3..0a3719d4aaf401902b67ef3a8ffe55232bf0e35e 100644

--- a/content/browser/accessibility/browser_accessibility.cc

+++ b/content/browser/accessibility/browser_accessibility.cc

@@ -663,6 +663,12 @@ bool BrowserAccessibility::HasState(ui::AXState state_enum) const {

return (GetState() >> state_enum) & 1;

}

+bool BrowserAccessibility::IsCellOrTableHeaderRole() const {

+ return (GetRole() == ui::AX_ROLE_CELL ||

+ GetRole() == ui::AX_ROLE_COLUMN_HEADER ||

+ GetRole() == ui::AX_ROLE_ROW_HEADER);

bool BrowserAccessibility::IsEditableText() const {

// These roles don't have readonly set, but they're not editable text.

if (GetRole() == ui::AX_ROLE_SCROLL_AREA ||