win: Add implementation of ScopedTempDir

win: Add implementation of ScopedTempDir

Also fix implementation of CreateFile which aborted at runtime
when provided POSIX-style permissions.

R=mark@chromium.org
BUG=crashpad:1
Committed: https://chromium.googlesource.com/crashpad/crashpad/+/7115130043bf2628783cdd805d29b767f5c55243

[scottmg, 2015-01-09 07:23:28]

Patchset #1 (id:1) has been deleted

[scottmg, 2015-01-09 07:23:32]

Patchset #1 (id:20001) has been deleted

[scottmg, 2015-01-09 07:26:34]

scottmg@chromium.org changed reviewers:
+ rsesek@chromium.org

[Mark Mentovai, 2015-01-09 14:13:47]

mark@chromium.org changed reviewers:
+ mark@chromium.org

[Mark Mentovai, 2015-01-09 14:13:47]

https://codereview.chromium.org/837123005/diff/60001/util/test/scoped_temp_di...
File util/test/scoped_temp_dir_win.cc (right):

https://codereview.chromium.org/837123005/diff/60001/util/test/scoped_temp_di...
util/test/scoped_temp_dir_win.cc:41: "%d_%d", GetCurrentProcessId(),
base::RandInt(0, 65536)));
Can we put something about crashpad in the name so that it’s identifiable?

Why limit the random number to only 65536?

https://codereview.chromium.org/837123005/diff/60001/util/test/scoped_temp_di...
util/test/scoped_temp_dir_win.cc:58: wchar_t double_terminated_path[MAX_PATH +
1] = {0};
Because this uses clobber-prone wcscpy, it should be defensive about a path
argument longer than MAX_PATH.

Instead, how about

  base::string16 double_terminated_path(path);
  double_terminated_path += L'\0';

?

https://codereview.chromium.org/837123005/diff/60001/util/test/scoped_temp_di...
util/test/scoped_temp_dir_win.cc:65: int err = SHFileOperation(&file_operation);
I’m kinda unimpressed by this function expanding wildcards and that kind of
thing. It does a little more than we really need or want.

[scottmg, 2015-01-13 21:18:29]

Patchset #3 (id:80001) has been deleted

[scottmg, 2015-01-13 21:19:30]

scottmg@chromium.org changed reviewers:
- rsesek@chromium.org

[scottmg, 2015-01-13 21:20:56]

https://codereview.chromium.org/837123005/diff/60001/util/test/scoped_temp_di...
File util/test/scoped_temp_dir_win.cc (right):

https://codereview.chromium.org/837123005/diff/60001/util/test/scoped_temp_di...
util/test/scoped_temp_dir_win.cc:41: "%d_%d", GetCurrentProcessId(),
base::RandInt(0, 65536)));
On 2015/01/09 14:13:47, Mark Mentovai wrote:
> Can we put something about crashpad in the name so that it’s identifiable?
> 
> Why limit the random number to only 65536?

Done.

https://codereview.chromium.org/837123005/diff/60001/util/test/scoped_temp_di...
util/test/scoped_temp_dir_win.cc:65: int err = SHFileOperation(&file_operation);
On 2015/01/09 14:13:47, Mark Mentovai wrote:
> I’m kinda unimpressed by this function expanding wildcards and that kind of
> thing. It does a little more than we really need or want.

OK. Mostly was based on ::RemoveDirectory suggesting it and Chrome's base using
it. But switched to a DeleteFile/RemoveDirectory version.

[Mark Mentovai, 2015-01-13 21:38:32]

LGTM. The weird semantics of Chrome’s equivalent and the cross-platform
differences were why we avoided using it here.

https://codereview.chromium.org/837123005/diff/100001/util/test/scoped_temp_d...
File util/test/scoped_temp_dir_win.cc (right):

https://codereview.chromium.org/837123005/diff/100001/util/test/scoped_temp_d...
util/test/scoped_temp_dir_win.cc:41: "crashpad.test.%d.%I64u",
GetCurrentProcessId(), base::RandUint64()));
x instead of u to conserve a few characters?

[scottmg, 2015-01-13 21:42:46]

https://codereview.chromium.org/837123005/diff/100001/util/test/scoped_temp_d...
File util/test/scoped_temp_dir_win.cc (right):

https://codereview.chromium.org/837123005/diff/100001/util/test/scoped_temp_d...
util/test/scoped_temp_dir_win.cc:41: "crashpad.test.%d.%I64u",
GetCurrentProcessId(), base::RandUint64()));
On 2015/01/13 21:38:32, Mark Mentovai wrote:
> x instead of u to conserve a few characters?

Done.

[scottmg, 2015-01-13 21:51:36]

Committed patchset #4 (id:120001) manually as
7115130043bf2628783cdd805d29b767f5c55243 (presubmit successful).