util/test/scoped_temp_dir_test.cc - Issue 837123005: win: Add implementation of ScopedTempDir

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: util/test/scoped_temp_dir_test.cc

Issue 837123005: win: Add implementation of ScopedTempDir (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master

Patch Set: x instead of u Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: util/test/scoped_temp_dir_test.cc

diff --git a/util/test/scoped_temp_dir_test.cc b/util/test/scoped_temp_dir_test.cc

index 7815405a267c54cf3b1bd181ea8206d27975639e..9701a69aa946db5771cec8a6554fe7e8ce12e65b 100644

--- a/util/test/scoped_temp_dir_test.cc

+++ b/util/test/scoped_temp_dir_test.cc

@@ -62,7 +62,7 @@ void CreateFile(const base::FilePath& path) {

ASSERT_EQ(0, IGNORE_EINTR(close(fd)))

<< ErrnoMessage("close") << " " << path.value();

#elif defined(OS_WIN)

- int fd = _wcreat(path.value().c_str(), 0644);

+ int fd = _wcreat(path.value().c_str(), _S_IREAD | _S_IWRITE);

ASSERT_GE(fd, 0) << ErrnoMessage("_wcreat") << " " << path.value();

ASSERT_EQ(0, _close(fd)) << ErrnoMessage("_close") << " " << path.value();

#else

« no previous file with comments | « util/test/scoped_temp_dir_posix.cc ('k') | util/test/scoped_temp_dir_win.cc » ('j') | no next file with comments »