Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 837113003: Fix host delete. Delete always returns a 204 (empty response), which will throw an "authentication … (Closed)

Created:
5 years, 11 months ago by rmsousa
Modified:
5 years, 11 months ago
Reviewers:
jamiewalch, Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix host delete. Delete always returns a 204 (empty response), which will throw an "authentication failed" error with the current code. More generally, HTTP 2xx statuses are always success, and should be treated as such. Also fix the error -> status terminology. R=jamiewalch BUG= Committed: https://crrev.com/90608d11ac3142c4a7a9fe560445f6b0bb729517 Cr-Commit-Position: refs/heads/master@{#312536}

Patch Set 1 #

Patch Set 2 : Merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -15 lines) Patch
M remoting/webapp/app_remoting/js/app_remoting.js View 1 1 chunk +1 line, -1 line 0 comments Download
M remoting/webapp/crd/js/error.js View 1 1 chunk +8 lines, -8 lines 0 comments Download
M remoting/webapp/crd/js/host_list_api_impl.js View 1 1 chunk +1 line, -1 line 0 comments Download
M remoting/webapp/crd/js/oauth2_api_impl.js View 1 4 chunks +4 lines, -4 lines 0 comments Download
M remoting/webapp/crd/js/xhr.js View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
rmsousa
5 years, 11 months ago (2015-01-21 00:35:30 UTC) #1
Jamie
lgtm
5 years, 11 months ago (2015-01-21 01:12:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/837113003/1
5 years, 11 months ago (2015-01-21 23:28:38 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/116282) android_aosp on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/builds/50627) ios_dbg_simulator ...
5 years, 11 months ago (2015-01-21 23:34:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/837113003/20001
5 years, 11 months ago (2015-01-22 00:53:30 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-22 02:36:46 UTC) #10
commit-bot: I haz the power
5 years, 11 months ago (2015-01-22 02:38:17 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/90608d11ac3142c4a7a9fe560445f6b0bb729517
Cr-Commit-Position: refs/heads/master@{#312536}

Powered by Google App Engine
This is Rietveld 408576698