remoting/webapp/app_remoting/js/app_remoting.js - Issue 837113003: Fix host delete. Delete always returns a 204 (empty response), which will throw an "authentication …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/webapp/app_remoting/js/app_remoting.js

Issue 837113003: Fix host delete. Delete always returns a 204 (empty response), which will throw an "authentication … (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merge Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: remoting/webapp/app_remoting/js/app_remoting.js

diff --git a/remoting/webapp/app_remoting/js/app_remoting.js b/remoting/webapp/app_remoting/js/app_remoting.js

index 6ca09f58a4953d27dd3f25d2fba6d6f097af5cfc..626cbf4b71c27931586a50add7b49edc05c76cb0 100644

--- a/remoting/webapp/app_remoting/js/app_remoting.js

+++ b/remoting/webapp/app_remoting/js/app_remoting.js

@@ -165,7 +165,7 @@ remoting.AppRemoting.prototype.init = function(connector) {

}

} else {

console.error('Invalid "runApplication" response from server.');

- // TODO(garykac) Start using remoting.Error.fromHttpError once it has

+ // TODO(garykac) Start using remoting.Error.fromHttpStatus once it has

// been updated to properly report 'unknown' errors (rather than

// reporting them as AUTHENTICATION_FAILED).

if (xhr.status == 0) {

« no previous file with comments | « no previous file | remoting/webapp/crd/js/error.js » ('j') | no next file with comments »