Fix function name in error message of scoped_temp_dir_test

Fix function name in error message of scoped_temp_dir_test

After https://codereview.chromium.org/826003003/.

R=mark@chromium.org

Committed: https://chromium.googlesource.com/crashpad/crashpad/+/a277e14c9ed98e6c8474868131634bac95093b6e

[Robert Sesek, 2015-01-08 17:40:30]

rsesek@chromium.org changed reviewers:
+ rsesek@chromium.org

[Robert Sesek, 2015-01-08 17:40:30]

https://codereview.chromium.org/836833003/diff/1/util/test/scoped_temp_dir_te...
File util/test/scoped_temp_dir_test.cc (right):

https://codereview.chromium.org/836833003/diff/1/util/test/scoped_temp_dir_te...
util/test/scoped_temp_dir_test.cc:77: << ErrnoMessage("mkdir") << " " <<
path.value();
You could use this same pattern here, too.

[Mark Mentovai, 2015-01-08 17:40:45]

LGTM otherwise

https://codereview.chromium.org/836833003/diff/1/util/test/scoped_temp_dir_te...
File util/test/scoped_temp_dir_test.cc (right):

https://codereview.chromium.org/836833003/diff/1/util/test/scoped_temp_dir_te...
util/test/scoped_temp_dir_test.cc:42: const char* stat_function = "lstat";
For char constants, use:

  const char stat_function[]

to prevent someone from being able to repoint the pointer at the wrong thing,
like

  stat_function = "some_other_const_char_array";

[scottmg, 2015-01-08 18:20:12]

Patchset #2 (id:20001) has been deleted

[scottmg, 2015-01-08 18:25:55]

https://codereview.chromium.org/836833003/diff/1/util/test/scoped_temp_dir_te...
File util/test/scoped_temp_dir_test.cc (right):

https://codereview.chromium.org/836833003/diff/1/util/test/scoped_temp_dir_te...
util/test/scoped_temp_dir_test.cc:42: const char* stat_function = "lstat";
On 2015/01/08 17:40:44, Mark Mentovai wrote:
> For char constants, use:
> 
>   const char stat_function[]
> 
> to prevent someone from being able to repoint the pointer at the wrong thing,
> like
> 
>   stat_function = "some_other_const_char_array";

Done.

https://codereview.chromium.org/836833003/diff/1/util/test/scoped_temp_dir_te...
util/test/scoped_temp_dir_test.cc:77: << ErrnoMessage("mkdir") << " " <<
path.value();
On 2015/01/08 17:40:30, Robert Sesek wrote:
> You could use this same pattern here, too.

Seems more verbose here since it's only one statement already, and includes the
assert.

[Mark Mentovai, 2015-01-08 18:58:49]

LGTM

[scottmg, 2015-01-08 19:08:39]

Committed patchset #2 (id:40001) manually as
a277e14c9ed98e6c8474868131634bac95093b6e (presubmit successful).