Fix function name in error message of scoped_temp_dir_test

util/test/scoped_temp_dir_test.cc

 // Copyright 2015 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 21 matching lines @@
 #endif  // OS_POSIX
 
 namespace crashpad {
 namespace test {
 namespace {
 
 bool FileExists(const base::FilePath& path) {
 #if defined(OS_POSIX)
   struct stat st;
   int rv = lstat(path.value().c_str(), &st);
+  const char* stat_function = "lstat";

[Mark Mentovai, 2015/01/08 17:40:44]

For char constants, use:

  const char stat_function[]

to prevent someone from being able to repoint the pointer at the wrong thing,
like

  stat_function = "some_other_const_char_array";

[scottmg, 2015/01/08 18:25:55]

Done.

 #elif defined(OS_WIN)
   struct _stat st;
   int rv = _wstat(path.value().c_str(), &st);
+  const char* stat_function = "_wstat";
 #else
 #error "Not implemented"
 #endif
   if (rv < 0) {
-    EXPECT_EQ(ENOENT, errno) << ErrnoMessage("lstat") << " " << path.value();
+    EXPECT_EQ(ENOENT, errno) << ErrnoMessage(stat_function) << " "
+                             << path.value();
     return false;
   }
   return true;
 }
 
 void CreateFile(const base::FilePath& path) {
 #if defined(OS_POSIX)
   int fd = HANDLE_EINTR(creat(path.value().c_str(), 0644));
   ASSERT_GE(fd, 0) << ErrnoMessage("creat") << " " << path.value();
   ASSERT_EQ(0, IGNORE_EINTR(close(fd)))
       << ErrnoMessage("close") << " " << path.value();
 #elif defined(OS_WIN)
   int fd = _wcreat(path.value().c_str(), 0644);
   ASSERT_GE(fd, 0) << ErrnoMessage("_wcreat") << " " << path.value();
   ASSERT_EQ(0, _close(fd)) << ErrnoMessage("_close") << " " << path.value();
 #else
 #error "Not implemented"
 #endif
   EXPECT_TRUE(FileExists(path));
 }
 
 void CreateDirectory(const base::FilePath& path) {
 #if defined(OS_POSIX)
   ASSERT_EQ(0, mkdir(path.value().c_str(), 0755))
       << ErrnoMessage("mkdir") << " " << path.value();

[Robert Sesek, 2015/01/08 17:40:30]

You could use this same pattern here, too.

[scottmg, 2015/01/08 18:25:55]

Seems more verbose here since it's only one statement already, and includes the
assert.

 #elif defined(OS_WIN)
   ASSERT_EQ(0, _wmkdir(path.value().c_str()))
       << ErrnoMessage("_wmkdir") << " " << path.value();
 #else
 #error "Not implemented"
 #endif
   ASSERT_TRUE(FileExists(path));
 }
 
 TEST(ScopedTempDir, Empty) {
@@ skipping 46 matching lines @@
 
   EXPECT_FALSE(FileExists(file1));
   EXPECT_FALSE(FileExists(file2));
   EXPECT_FALSE(FileExists(child_dir));
   EXPECT_FALSE(FileExists(parent));
 }
 
 }  // namespace
 }  // namespace test
 }  // namespace crashpad