Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Unified Diff: Source/modules/accessibility/AXNodeObject.cpp

Issue 836553002: Accessible name not calculated properly (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/accessibility/aria-labelledby-on-input-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/accessibility/AXNodeObject.cpp
diff --git a/Source/modules/accessibility/AXNodeObject.cpp b/Source/modules/accessibility/AXNodeObject.cpp
index f60bf63eb7f89e91d50400f4fcd0b0aaa64cd718..86887b5b8f1b99c4e5586d29eca2311163074ceb 100644
--- a/Source/modules/accessibility/AXNodeObject.cpp
+++ b/Source/modules/accessibility/AXNodeObject.cpp
@@ -93,6 +93,12 @@ static String accessibleNameForNode(Node* node)
return alt;
}
+ if (node->isHTMLElement()) {
dmazzoni 2015/01/27 06:40:46 Just combine this into the block above: if (node-
+ const AtomicString& title = toHTMLElement(node)->getAttribute(titleAttr);
+ if (!title.isEmpty())
+ return title;
+ }
+
return String();
}
« no previous file with comments | « LayoutTests/accessibility/aria-labelledby-on-input-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698