Accessible name not calculated properly

Source/modules/accessibility/AXNodeObject.cpp

 /*
 * Copyright (C) 2012, Google Inc. All rights reserved.
 *
 * Redistribution and use in source and binary forms, with or without
 * modification, are permitted provided that the following conditions
 * are met:
 *
 * 1.  Redistributions of source code must retain the above copyright
 *     notice, this list of conditions and the following disclaimer.
 * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 75 matching lines @@
 
     if (isHTMLInputElement(*node))
         return toHTMLInputElement(*node).value();
 
     if (node->isHTMLElement()) {
         const AtomicString& alt = toHTMLElement(node)->getAttribute(altAttr);
         if (!alt.isEmpty())
             return alt;
     }
 
+    if (node->isHTMLElement()) {

[dmazzoni, 2015/01/27 06:40:46]

Just combine this into the block above:

if (node->isHTMLElement()) {
    const AtomicString& alt = toHTMLElement(node)->getAttribute(altAttr);
    if (!alt.isEmpty())
        return alt;

    const AtomicString& title = toHTMLElement(node)->getAttribute(titleAttr);
    if (!title.isEmpty())
        return title;
}

+        const AtomicString& title = toHTMLElement(node)->getAttribute(titleAttr);
+        if (!title.isEmpty())
+            return title;
+    }
+
     return String();
 }
 
 String AXNodeObject::accessibilityDescriptionForElements(WillBeHeapVector<RawPtrWillBeMember<Element> > &elements) const
 {
     StringBuilder builder;
     unsigned size = elements.size();
     for (unsigned i = 0; i < size; ++i) {
         Element* idElement = elements[i];
 
@@ skipping 1838 matching lines @@
     float range = maxValueForRange() - minValueForRange();
     float value = valueForRange();
 
     value += range * (percentChange / 100);
     setValue(String::number(value));
 
     axObjectCache()->postNotification(node(), AXObjectCacheImpl::AXValueChanged, true);
 }
 
 } // namespace blink