Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(831)

Issue 836553002: Accessible name not calculated properly (Closed)

Created:
5 years, 11 months ago by ramya.v
Modified:
5 years, 11 months ago
Reviewers:
dmazzoni, aboxhall
CC:
blink-reviews, dmazzoni, aboxhall
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Accessible name not calculated properly BUG=426347 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189028

Patch Set 1 #

Total comments: 1

Patch Set 2 : Updated as per review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M LayoutTests/accessibility/aria-labelledby-on-input.html View 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/accessibility/aria-labelledby-on-input-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/accessibility/AXNodeObject.cpp View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
ramya.v
PTAL! Thanks
5 years, 11 months ago (2015-01-02 14:20:43 UTC) #2
ramya.v
On 2015/01/02 14:20:43, ramya.v wrote: > PTAL! > > Thanks @dominic Could you please review ...
5 years, 11 months ago (2015-01-27 03:06:14 UTC) #3
dmazzoni
lgtm https://codereview.chromium.org/836553002/diff/1/Source/modules/accessibility/AXNodeObject.cpp File Source/modules/accessibility/AXNodeObject.cpp (right): https://codereview.chromium.org/836553002/diff/1/Source/modules/accessibility/AXNodeObject.cpp#newcode96 Source/modules/accessibility/AXNodeObject.cpp:96: if (node->isHTMLElement()) { Just combine this into the ...
5 years, 11 months ago (2015-01-27 06:40:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/836553002/20001
5 years, 11 months ago (2015-01-27 10:16:22 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-27 12:20:01 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189028

Powered by Google App Engine
This is Rietveld 408576698