Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 8365028: Merge 97745 - REGRESSION(r97248): :visited as descendant selector broken (Closed)

Created:
9 years, 2 months ago by tkent
Modified:
9 years, 2 months ago
Reviewers:
tkent
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/912/
Visibility:
Public.

Description

Merge 97745 - REGRESSION(r97248): :visited as descendant selector broken https://bugs.webkit.org/show_bug.cgi?id=70122 Source/WebCore: Reviewed by Nikolas Zimmerman. Make ":visited foo" and similar selectors work correctly again. They can affect the visited style of an element inside a visited link. Test: fast/selectors/visited-descendant.html * css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyDeclarations): Apply visited style to children of visited links too. * css/SelectorChecker.cpp: (WebCore::SelectorChecker::checkSelector): Don't disable visited matching until we run into first ancestor link or use combinator other than child/descendant. (WebCore::SelectorChecker::determineLinkMatchType): Look into child/descendant component selectors too to determine the link match type. LayoutTests: Reviewed by Nikolas Zimmerman. * fast/selectors/visited-descendant.html: Added. * platform/mac/fast/selectors/visited-descendant-expected.txt: Added. TBR=tkent@chromium.org BUG=crbug.com/101023 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98067

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
A + LayoutTests/fast/selectors/visited-descendant.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/platform/mac/fast/selectors/visited-descendant-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/css/CSSStyleSelector.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/css/SelectorChecker.cpp View 3 chunks +11 lines, -7 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
tkent
9 years, 2 months ago (2011-10-21 05:46:18 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698