Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Issue 836473006: MIPS: tweak register constraint to build under clang (Closed)

Created:
5 years, 11 months ago by vapier
Modified:
5 years, 11 months ago
Reviewers:
Lei Zhang, Ben Chan
CC:
chromium-reviews, Markus (顧孟勤), Mark Seaborn, npennequin
Visibility:
Public.

Description

MIPS: tweak register constraint to build under clang The constraints used for passing in the syscall number breaks when building with clang: .../lss/linux_syscall_support.h:2977:14: error: invalid input constraint '0' in asm LSS_INLINE _syscall1(void *, brk, void *, e) ^ This might be a bug in clang itself, but we can tweak the constraints on our side so it works with gcc & clang. BUG=http://llvm.org/bugs/show_bug.cgi?id=21613 BUG=linux-syscall-support:9 TEST=gcc generates same asm before & after TEST=clang now compiles R=benchan@chromium.org Committed: https://code.google.com/p/linux-syscall-support/source/detail?r=33

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M lss/linux_syscall_support.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
vapier
5 years, 11 months ago (2015-01-16 12:06:09 UTC) #2
Ben Chan
lgtm
5 years, 11 months ago (2015-01-22 16:44:33 UTC) #3
vapier
5 years, 11 months ago (2015-01-22 16:46:43 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r33 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698