Issue 836413004: win: avoid warning in StringFileWriter.SeekInvalid test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 836413004: win: avoid warning in StringFileWriter.SeekInvalid test (Closed)

Created:
5 years, 11 months ago by scottmg

Modified:
5 years, 11 months ago

Reviewers:
Mark Mentovai

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master

Target Ref:
refs/heads/master

Project:
crashpad

Visibility:
Public.

win: avoid warning in StringFileWriter.SeekInvalid test d:\src\crashpad\crashpad\util\file\string_file_writer_test.cc(367) : warning C4244: 'initializing' : conversion from 'const uint64_t' to 'const off_t', possible loss of data R=mark@chromium.org BUG=crashpad:1 Committed: https://chromium.googlesource.com/crashpad/crashpad/+/4ec54051357f33ef3e1c718a3a17a9237ef575de

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	util/file/string_file_writer_test.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

Mark Mentovai

LGTM. It’s pretty sad that this is what it takes to safely mix distinct data ...

5 years, 11 months ago (2015-01-07 22:35:49 UTC) #2

Mark Mentovai

(not so much the new static_cast, but the existing min and implicit_casts too.)

5 years, 11 months ago (2015-01-07 22:36:08 UTC) #3

scottmg

5 years, 11 months ago (2015-01-07 22:42:59 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
4ec54051357f33ef3e1c718a3a17a9237ef575de (presubmit successful).