Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1118)

Unified Diff: util/file/string_file_writer_test.cc

Issue 836413004: win: avoid warning in StringFileWriter.SeekInvalid test (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: util/file/string_file_writer_test.cc
diff --git a/util/file/string_file_writer_test.cc b/util/file/string_file_writer_test.cc
index ea26db3df6461756978a24a487144858dbbcf0d2..01b32369215bcbed4b46c19b3e78d01009f7680a 100644
--- a/util/file/string_file_writer_test.cc
+++ b/util/file/string_file_writer_test.cc
@@ -362,9 +362,9 @@ TEST(StringFileWriter, SeekInvalid) {
EXPECT_EQ(0, writer.Seek(0, SEEK_CUR));
EXPECT_TRUE(writer.string().empty());
- const off_t kMaxOffset =
+ const off_t kMaxOffset = static_cast<off_t>(
std::min(implicit_cast<uint64_t>(std::numeric_limits<off_t>::max()),
- implicit_cast<uint64_t>(std::numeric_limits<size_t>::max()));
+ implicit_cast<uint64_t>(std::numeric_limits<size_t>::max())));
EXPECT_EQ(kMaxOffset, writer.Seek(kMaxOffset, SEEK_SET));
EXPECT_EQ(kMaxOffset, writer.Seek(0, SEEK_CUR));
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698