Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 836393007: Update {virtual,override,final} for chrome/ to follow C++11 style. (Closed)

Created:
5 years, 11 months ago by dcheng
Modified:
5 years, 11 months ago
Reviewers:
James Hawkins
CC:
dcheng, chrome-apps-syd-reviews_chromium.org, chromium-reviews, Dmitry Titov, gcasto+watchlist_chromium.org, jam, jennb, jianli, mkwst+watchlist-passwords_chromium.org, stuartmorgan+watch_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update {virtual,override,final} for chrome/ to follow C++11 style. This patch was automatically generated using a variation of https://codereview.chromium.org/598073004 BUG=417463 Committed: https://crrev.com/8ae9dbff1b1ac8b13b5b3e2a2b2fbf4dbebf1210 Cr-Commit-Position: refs/heads/master@{#310830}

Patch Set 1 #

Patch Set 2 : Cleanups #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -26 lines) Patch
M chrome/browser/app_controller_mac_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/apps/app_shim/app_shim_host_mac_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/apps/app_shim/app_shim_host_manager_browsertest_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/apps/app_shim/app_shim_interactive_uitest_mac.mm View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/password_manager/password_store_mac_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/plugins/plugin_installer_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper_unit_test.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_service_mac_interactive_uitest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/app_list_service_mac_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/panels/panel_drag_browsertest.cc View 1 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/web_applications/web_app_mac_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/service_process_util_unittest.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/test/perf/mach_ports_performancetest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dcheng
5 years, 11 months ago (2015-01-08 23:53:16 UTC) #2
James Hawkins
lgtm
5 years, 11 months ago (2015-01-09 18:55:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/836393007/20001
5 years, 11 months ago (2015-01-09 19:09:42 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-09 19:51:11 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-09 19:53:39 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/8ae9dbff1b1ac8b13b5b3e2a2b2fbf4dbebf1210
Cr-Commit-Position: refs/heads/master@{#310830}

Powered by Google App Engine
This is Rietveld 408576698