chrome/browser/apps/app_shim/app_shim_interactive_uitest_mac.mm - Issue 836393007: Update {virtual,override,final} for chrome/ to follow C++11 style.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/apps/app_shim/app_shim_interactive_uitest_mac.mm

Issue 836393007: Update {virtual,override,final} for chrome/ to follow C++11 style. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Cleanups Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/apps/app_shim/app_shim_host_manager_browsertest_mac.mm ('k') | chrome/browser/password_manager/password_store_mac_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/apps/app_shim/app_shim_interactive_uitest_mac.mm

diff --git a/chrome/browser/apps/app_shim/app_shim_interactive_uitest_mac.mm b/chrome/browser/apps/app_shim/app_shim_interactive_uitest_mac.mm

index 2b1e0020325bb7f4e6c0bca6ca0752085509d3b3..5ea5e69ef048ea50601bb778facc61f269a3d9d1 100644

--- a/chrome/browser/apps/app_shim/app_shim_interactive_uitest_mac.mm

+++ b/chrome/browser/apps/app_shim/app_shim_interactive_uitest_mac.mm

@@ -163,7 +163,9 @@ class HostedAppBrowserListObserver : public chrome::BrowserListObserver {

BrowserList::AddObserver(this);

}

- ~HostedAppBrowserListObserver() { BrowserList::RemoveObserver(this); }

+ ~HostedAppBrowserListObserver() override {

+ BrowserList::RemoveObserver(this);

+ }

void WaitUntilAdded() {

if (observed_add_)

@@ -217,7 +219,7 @@ class AppLifetimeMonitorObserver : public apps::AppLifetimeMonitor::Observer {

: profile_(profile), activated_count_(0), deactivated_count_(0) {

apps::AppLifetimeMonitorFactory::GetForProfile(profile_)->AddObserver(this);

}

- virtual ~AppLifetimeMonitorObserver() {

+ ~AppLifetimeMonitorObserver() override {

apps::AppLifetimeMonitorFactory::GetForProfile(profile_)

->RemoveObserver(this);

}