Source/core/css/parser/MediaQueryParser.h - Issue 836373002: Make media query feature values more strict

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/parser/MediaQueryParser.h

Issue 836373002: Make media query feature values more strict (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add two more tests Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/parser/MediaQueryParser.h

diff --git a/Source/core/css/parser/MediaQueryParser.h b/Source/core/css/parser/MediaQueryParser.h

index 1d51217a84873acc63af160f6da539b29765894a..3b2c2aa4df0fc24b13a479e864586aa38d9322fa 100644

--- a/Source/core/css/parser/MediaQueryParser.h

+++ b/Source/core/css/parser/MediaQueryParser.h

@@ -32,7 +32,7 @@ public:

MediaQueryData();

void clear();

bool addExpression();

- void addParserValue(CSSParserTokenType, const CSSParserToken&);

+ bool tryAddParserValue(CSSParserTokenType, const CSSParserToken&);

void setMediaType(const String&);

PassOwnPtrWillBeRawPtr<MediaQuery> takeMediaQuery();