Source/core/css/MediaQueryEvaluatorTest.cpp - Issue 836373002: Make media query feature values more strict

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/MediaQueryEvaluatorTest.cpp

Issue 836373002: Make media query feature values more strict (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add two more tests Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/MediaQueryEvaluatorTest.cpp

diff --git a/Source/core/css/MediaQueryEvaluatorTest.cpp b/Source/core/css/MediaQueryEvaluatorTest.cpp

index 5b9ce59ee4032f99699c36f99ec3a501431d8f8a..17ecb8ed3dd9c8009c04e9de2522b58c9f538e0a 100644

--- a/Source/core/css/MediaQueryEvaluatorTest.cpp

+++ b/Source/core/css/MediaQueryEvaluatorTest.cpp

@@ -41,6 +41,13 @@ TestCase screenTestCases[] = {

{"(resolution: 1dppx)", 0},

{"(orientation: portrait)", 1},

{"(orientation: landscape)", 0},

+ {"(orientation: url(portrait))", 0},

+ {"(orientation: #portrait)", 0},

+ {"(orientation: @portrait)", 0},

+ {"(orientation: 'portrait')", 0},

+ {"(orientation: @junk portrait)", 0},

+ {"screen and (orientation: @portrait) and (max-width: 1000px)", 0},

+ {"screen and (orientation: @portrait), (max-width: 1000px)", 1},

{"tv and (scan: progressive)", 0},

{"(pointer: coarse)", 0},

{"(pointer: fine)", 1},

« no previous file with comments | « no previous file | Source/core/css/parser/MediaQueryParser.h » ('j') | no next file with comments »