chrome/browser/chromeos/power/peripheral_battery_observer_browsertest.cc - Issue 83633004: Do not spawn a thread in browser/interactive ui tests before spawning sandbox host process

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/power/peripheral_battery_observer_browsertest.cc

Issue 83633004: Do not spawn a thread in browser/interactive ui tests before spawning sandbox host process (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/apps/app_browsertest.cc ('K') | « chrome/browser/chromeos/policy/device_policy_cros_browser_test.cc ('k') | chrome/browser/extensions/api/system_private/system_private_apitest.cc » ('j') | chromeos/dbus/dbus_thread_manager.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/power/peripheral_battery_observer_browsertest.cc

diff --git a/chrome/browser/chromeos/power/peripheral_battery_observer_browsertest.cc b/chrome/browser/chromeos/power/peripheral_battery_observer_browsertest.cc

index c14d41d62feba11aa50552a809c9c9d54003fd66..1e6e8e974ae4a4ae3874c8280adc5b7311e4ce8b 100644

--- a/chrome/browser/chromeos/power/peripheral_battery_observer_browsertest.cc

+++ b/chrome/browser/chromeos/power/peripheral_battery_observer_browsertest.cc

@@ -40,7 +40,7 @@ class PeripheralBatteryObserverTest : public InProcessBrowserTest {

FakeDBusThreadManager* fake_dbus_thread_manager =

new FakeDBusThreadManager;

fake_dbus_thread_manager->SetFakeClients();

- DBusThreadManager::InitializeForTesting(fake_dbus_thread_manager);

+ DBusThreadManager::SetInstanceForTesting(fake_dbus_thread_manager);

InProcessBrowserTest::SetUpInProcessBrowserTestFixture();

}

@@ -54,7 +54,6 @@ class PeripheralBatteryObserverTest : public InProcessBrowserTest {

virtual void TearDownInProcessBrowserTestFixture() OVERRIDE {

InProcessBrowserTest::TearDownInProcessBrowserTestFixture();

- DBusThreadManager::Shutdown();

}

protected: