Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4954)

Unified Diff: chrome/browser/apps/app_browsertest.cc

Issue 83633004: Do not spawn a thread in browser/interactive ui tests before spawning sandbox host process (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/apps/app_browsertest.cc
diff --git a/chrome/browser/apps/app_browsertest.cc b/chrome/browser/apps/app_browsertest.cc
index 595add90c9cc071e2b2929c90bd5c0755584a48c..e6f57290526a256fdd9d3f0cd001e5e91e4b7af0 100644
--- a/chrome/browser/apps/app_browsertest.cc
+++ b/chrome/browser/apps/app_browsertest.cc
@@ -1251,7 +1251,7 @@ class RestartDeviceTest : public PlatformAppBrowserTest {
power_manager_client_ = new chromeos::FakePowerManagerClient;
dbus_manager->SetPowerManagerClient(
scoped_ptr<chromeos::PowerManagerClient>(power_manager_client_));
- chromeos::DBusThreadManager::InitializeForTesting(dbus_manager);
+ chromeos::DBusThreadManager::SetInstanceForTesting(dbus_manager);
}
virtual void SetUpOnMainThread() OVERRIDE {
@@ -1273,7 +1273,6 @@ class RestartDeviceTest : public PlatformAppBrowserTest {
}
virtual void TearDownInProcessBrowserTestFixture() OVERRIDE {
- chromeos::DBusThreadManager::Shutdown();
satorux1 2013/11/27 03:27:17 Is it ok to remove this? I thought FakeDBusThreadM
oshima 2013/11/27 07:41:54 Yes, this wasn't necessary because Shutdown is cal
PlatformAppBrowserTest::TearDownInProcessBrowserTestFixture();
}
« no previous file with comments | « no previous file | chrome/browser/chromeos/login/crash_restore_browsertest.cc » ('j') | chromeos/dbus/dbus_thread_manager.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698