Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Unified Diff: chrome/browser/autocomplete/search_provider_unittest.cc

Issue 836213002: Assume all providers may give zero suggest responses. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix compilation issue in athena Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autocomplete/search_provider_unittest.cc
diff --git a/chrome/browser/autocomplete/search_provider_unittest.cc b/chrome/browser/autocomplete/search_provider_unittest.cc
index 067a3c1c56d7691f52f8d5071cb310767a623fa9..dcb21bfc7add01f4c6527f335225184b0b814f7f 100644
--- a/chrome/browser/autocomplete/search_provider_unittest.cc
+++ b/chrome/browser/autocomplete/search_provider_unittest.cc
@@ -343,7 +343,7 @@ void SearchProviderTest::RunTest(TestData* cases,
metrics::OmniboxEventProto::INVALID_SPEC, false,
prefer_keyword, true, true,
ChromeAutocompleteSchemeClassifier(&profile_));
- provider_->Start(input, false);
+ provider_->Start(input, false, false);
matches = provider_->matches();
SCOPED_TRACE(
ASCIIToUTF16("Input was: ") +
@@ -388,7 +388,7 @@ void SearchProviderTest::QueryForInput(const base::string16& text,
metrics::OmniboxEventProto::INVALID_SPEC,
prevent_inline_autocomplete, prefer_keyword, true,
true, ChromeAutocompleteSchemeClassifier(&profile_));
- provider_->Start(input, false);
+ provider_->Start(input, false, false);
// RunUntilIdle so that the task scheduled by SearchProvider to create the
// URLFetchers runs.
@@ -3471,3 +3471,13 @@ TEST_F(SearchProviderTest, RemoveExtraAnswers) {
EXPECT_TRUE(matches[4].answer_type.empty());
EXPECT_FALSE(matches[4].answer);
}
+
+TEST_F(SearchProviderTest, DoesNotProvideOnFocus) {
+ AutocompleteInput input(base::ASCIIToUTF16("f"), base::string16::npos,
+ std::string(), GURL(),
+ metrics::OmniboxEventProto::INVALID_SPEC, false,
+ true, true, true,
+ ChromeAutocompleteSchemeClassifier(&profile_));
+ provider_->Start(input, false, true);
+ EXPECT_TRUE(provider_->matches().empty());
+}
« no previous file with comments | « chrome/browser/autocomplete/history_url_provider_unittest.cc ('k') | chrome/browser/autocomplete/shortcuts_provider.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698