Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(943)

Unified Diff: chrome/browser/autocomplete/history_url_provider_unittest.cc

Issue 836213002: Assume all providers may give zero suggest responses. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix compilation issue in athena Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autocomplete/history_url_provider_unittest.cc
diff --git a/chrome/browser/autocomplete/history_url_provider_unittest.cc b/chrome/browser/autocomplete/history_url_provider_unittest.cc
index d35a785b8494a3a7abc3b382777d2fe0531dfea2..1e91d826fe573bfe46caaddddc9b29bdcc136b03 100644
--- a/chrome/browser/autocomplete/history_url_provider_unittest.cc
+++ b/chrome/browser/autocomplete/history_url_provider_unittest.cc
@@ -310,7 +310,7 @@ void HistoryURLProviderTest::RunTest(
prevent_inline_autocomplete, false, true, true,
ChromeAutocompleteSchemeClassifier(profile_.get()));
*identified_input_type = input.type();
- autocomplete_->Start(input, false);
+ autocomplete_->Start(input, false, false);
if (!autocomplete_->done())
base::MessageLoop::current()->Run();
@@ -610,7 +610,7 @@ TEST_F(HistoryURLProviderTest, EmptyVisits) {
metrics::OmniboxEventProto::INVALID_SPEC, false,
false, true, true,
ChromeAutocompleteSchemeClassifier(profile_.get()));
- autocomplete_->Start(input, false);
+ autocomplete_->Start(input, false, false);
// HistoryURLProvider shouldn't be done (waiting on async results).
EXPECT_FALSE(autocomplete_->done());
@@ -653,7 +653,7 @@ TEST_F(HistoryURLProviderTest, DontAutocompleteOnTrailingWhitespace) {
metrics::OmniboxEventProto::INVALID_SPEC, false,
false, true, true,
ChromeAutocompleteSchemeClassifier(profile_.get()));
- autocomplete_->Start(input, false);
+ autocomplete_->Start(input, false, false);
if (!autocomplete_->done())
base::MessageLoop::current()->Run();
@@ -791,12 +791,22 @@ TEST_F(HistoryURLProviderTest, CrashDueToFixup) {
metrics::OmniboxEventProto::INVALID_SPEC,
false, false, true, true,
ChromeAutocompleteSchemeClassifier(profile_.get()));
- autocomplete_->Start(input, false);
+ autocomplete_->Start(input, false, false);
if (!autocomplete_->done())
base::MessageLoop::current()->Run();
}
}
+TEST_F(HistoryURLProviderTest, DoesNotProvideMatchesOnFocus) {
+ AutocompleteInput input(ASCIIToUTF16("foo"), base::string16::npos,
+ std::string(), GURL(),
+ metrics::OmniboxEventProto::INVALID_SPEC,
+ false, false, true, true,
+ ChromeAutocompleteSchemeClassifier(profile_.get()));
+ autocomplete_->Start(input, false, true);
+ EXPECT_TRUE(autocomplete_->matches().empty());
+}
+
TEST_F(HistoryURLProviderTest, CullSearchResults) {
// Set up a default search engine.
TemplateURLData data;
« no previous file with comments | « chrome/browser/autocomplete/history_url_provider.cc ('k') | chrome/browser/autocomplete/search_provider_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698