Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6726)

Unified Diff: components/omnibox/autocomplete_provider.h

Issue 836213002: Assume all providers may give zero suggest responses. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: A style fix Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/omnibox/autocomplete_provider.h
diff --git a/components/omnibox/autocomplete_provider.h b/components/omnibox/autocomplete_provider.h
index 96102928a62bb1f3153d3a541f0d7916e0296a2d..f209e43a2f8077a2681763778e78ef75597fb132 100644
--- a/components/omnibox/autocomplete_provider.h
+++ b/components/omnibox/autocomplete_provider.h
@@ -156,7 +156,13 @@ class AutocompleteProvider
// |minimal_changes| is an optimization that lets the provider do less work
// when the |input|'s text hasn't changed. See the body of
// OmniboxPopupModel::StartAutocomplete().
- virtual void Start(const AutocompleteInput& input, bool minimal_changes) = 0;
+ //
+ // |on_focus| is set to true when autocomplete provider is triggered through
+ // omnibox focus rather than input and should only return matches expected
+ // on focus.
Peter Kasting 2015/01/07 20:16:36 How about this: // |called_due_to_focus| is tru
Maria 2015/01/08 07:52:38 Done.
+ virtual void Start(const AutocompleteInput& input,
+ bool minimal_changes,
+ bool on_focus) = 0;
// Called when a provider must not make any more callbacks for the current
// query. This will be called regardless of whether the provider is already
@@ -197,10 +203,6 @@ class AutocompleteProvider
// Returns this provider's type.
Type type() const { return type_; }
- // Returns whether the provider wants to provide matches in response to the
- // omnibox being focused.
- virtual bool ProvidesMatchesOnOmniboxFocus() const;
-
// Returns a string describing this provider's type.
const char* GetName() const;

Powered by Google App Engine
This is Rietveld 408576698