chrome/browser/autocomplete/shortcuts_provider.cc - Issue 836213002: Assume all providers may give zero suggest responses.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/autocomplete/shortcuts_provider.cc

Issue 836213002: Assume all providers may give zero suggest responses. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: A style fix Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/autocomplete/bookmark_provider.cc ('K') | « chrome/browser/autocomplete/shortcuts_provider.h ('k') | chrome/browser/autocomplete/zero_suggest_provider.h » ('j') | components/omnibox/autocomplete_provider.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/autocomplete/shortcuts_provider.cc

diff --git a/chrome/browser/autocomplete/shortcuts_provider.cc b/chrome/browser/autocomplete/shortcuts_provider.cc

index 106cf1c68c992f777d08711d934d559a6b0acf15..0c74d92e13a704ead0659d71b3117ed5c574583e 100644

--- a/chrome/browser/autocomplete/shortcuts_provider.cc

+++ b/chrome/browser/autocomplete/shortcuts_provider.cc

@@ -67,9 +67,13 @@ ShortcutsProvider::ShortcutsProvider(Profile* profile)

}

void ShortcutsProvider::Start(const AutocompleteInput& input,

- bool minimal_changes) {

+ bool minimal_changes,

+ bool on_focus) {

matches_.clear();

+ if (on_focus)

Peter Kasting 2015/01/07 20:16:36 Nit: I would just combine all these conditions her

Maria 2015/01/08 07:52:38 Done.

+ return;

if ((input.type() == metrics::OmniboxInputType::INVALID) ||

(input.type() == metrics::OmniboxInputType::FORCED_QUERY))

return;