Add a method to set system UI visibility for ContentVideoView

Add a method to set system UI visibility for ContentVideoView

When long clicking a fullscreen video, Context menu will be shown.
This will reset the current system UI flags.
We need to change the system UI flags back when fullscreen activity gets back the focus.
Or an alternative approach is to disable the context menu for fullscreen video.

BUG=424134
Committed: https://crrev.com/b19cf562744bef367a0947b3096d8d777b7ea44d
Cr-Commit-Position: refs/heads/master@{#311710}

[qinmin, 2015-01-06 02:03:03]

qinmin@chromium.org changed reviewers:
+ tedchoc@chromium.org

[qinmin, 2015-01-06 02:03:03]

PTAL

[Ted C, 2015-01-09 22:31:54]

lgtm

https://codereview.chromium.org/836063003/diff/20001/content/public/android/j...
File
content/public/android/java/src/org/chromium/content/browser/ActivityContentVideoViewClient.java
(right):

https://codereview.chromium.org/836063003/diff/20001/content/public/android/j...
content/public/android/java/src/org/chromium/content/browser/ActivityContentVideoViewClient.java:55:
FrameLayout decor = (FrameLayout) mActivity.getWindow().getDecorView();
any reason why you're casting to FrameLayout?  Would View be sufficient here?

https://codereview.chromium.org/836063003/diff/20001/content/public/android/j...
File
content/public/android/java/src/org/chromium/content/browser/ContentVideoView.java
(right):

https://codereview.chromium.org/836063003/diff/20001/content/public/android/j...
content/public/android/java/src/org/chromium/content/browser/ContentVideoView.java:394:
public void onFullscreenWindowFocused() {
add javadoc

[qinmin, 2015-01-12 23:35:22]

https://codereview.chromium.org/836063003/diff/20001/content/public/android/j...
File
content/public/android/java/src/org/chromium/content/browser/ActivityContentVideoViewClient.java
(right):

https://codereview.chromium.org/836063003/diff/20001/content/public/android/j...
content/public/android/java/src/org/chromium/content/browser/ActivityContentVideoViewClient.java:55:
FrameLayout decor = (FrameLayout) mActivity.getWindow().getDecorView();
On 2015/01/09 22:31:54, Ted C wrote:
> any reason why you're casting to FrameLayout?  Would View be sufficient here?

Done.

https://codereview.chromium.org/836063003/diff/20001/content/public/android/j...
File
content/public/android/java/src/org/chromium/content/browser/ContentVideoView.java
(right):

https://codereview.chromium.org/836063003/diff/20001/content/public/android/j...
content/public/android/java/src/org/chromium/content/browser/ContentVideoView.java:394:
public void onFullscreenWindowFocused() {
On 2015/01/09 22:31:54, Ted C wrote:
> add javadoc

Done.

[qinmin, 2015-01-12 23:35:26]

The CQ bit was checked by qinmin@chromium.org

[commit-bot: I haz the power, 2015-01-12 23:36:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/836063003/40001

[commit-bot: I haz the power, 2015-01-12 23:53:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-12 23:53:34]

Try jobs failed on following builders:
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)

[qinmin, 2015-01-13 00:04:55]

The CQ bit was checked by qinmin@chromium.org

[commit-bot: I haz the power, 2015-01-13 00:06:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/836063003/60001

[commit-bot: I haz the power, 2015-01-13 00:14:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-13 00:14:31]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[qinmin, 2015-01-13 19:49:41]

The CQ bit was checked by qinmin@chromium.org

[qinmin, 2015-01-13 19:49:59]

The CQ bit was unchecked by qinmin@chromium.org

[qinmin, 2015-01-13 19:54:00]

qinmin@chromium.org changed reviewers:
+ michaelbai@chromium.org

[qinmin, 2015-01-13 19:54:01]

+michaelbai for android_webview OWNER

[michaelbai, 2015-01-13 22:14:38]

michaelbai@chromium.org changed reviewers:
+ igsolla@chromium.org

[michaelbai, 2015-01-13 22:15:01]

igsolla@ shall we do anything in WebView side?

[Ignacio Solla, 2015-01-15 13:47:37]

On 2015/01/13 22:15:01, michaelbai wrote:
> igsolla@ shall we do anything in WebView side?

The WebView does not show Context menus, this is a browser feature, so we don't
need to do anything about it.

[Ignacio Solla, 2015-01-15 13:48:56]

lgtm

[Ignacio Solla, 2015-01-15 13:48:58]

lgtm

[michaelbai, 2015-01-15 16:44:12]

lgtm

[qinmin, 2015-01-15 17:46:57]

The CQ bit was checked by qinmin@chromium.org

[commit-bot: I haz the power, 2015-01-15 17:47:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/836063003/80001

[commit-bot: I haz the power, 2015-01-15 19:25:26]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-01-15 19:26:19]

Patchset 5 (id:??) landed as
https://crrev.com/b19cf562744bef367a0947b3096d8d777b7ea44d
Cr-Commit-Position: refs/heads/master@{#311710}

[Anand Mistry (off Chromium), 2015-01-16 00:18:56]

On 2015/01/15 19:26:19, I haz the power (commit-bot) wrote:
> Patchset 5 (id:??) landed as
> https://crrev.com/b19cf562744bef367a0947b3096d8d777b7ea44d
> Cr-Commit-Position: refs/heads/master@{#311710}

I suspect this change may have broken the Android tests builders:
https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/1...

[qinmin, 2015-01-16 00:44:01]

On 2015/01/16 00:18:56, Anand Mistry wrote:
> On 2015/01/15 19:26:19, I haz the power (commit-bot) wrote:
> > Patchset 5 (id:??) landed as
> > https://crrev.com/b19cf562744bef367a0947b3096d8d777b7ea44d
> > Cr-Commit-Position: refs/heads/master@{#311710}
> 
> I suspect this change may have broken the Android tests builders:
>
https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/1...

Instrumentation test passed on #17804, so it doens't look like that this CL is
the cause. Probably the test itself is flaky