chrome/android/java/src/org/chromium/chrome/browser/fullscreen/ChromeFullscreenManager.java - Issue 836063003: Add a method to set system UI visibility for ContentVideoView

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/fullscreen/ChromeFullscreenManager.java

Issue 836063003: Add a method to set system UI visibility for ContentVideoView (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix TODO Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/java/src/org/chromium/android_webview/AwContentViewClient.java ('k') | content/public/android/java/src/org/chromium/content/browser/ActivityContentVideoViewClient.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/fullscreen/ChromeFullscreenManager.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/fullscreen/ChromeFullscreenManager.java b/chrome/android/java/src/org/chromium/chrome/browser/fullscreen/ChromeFullscreenManager.java

index 27c1180ef071fd4cd1539c7510872b53bb13117e..6e333490a663946eaff55221c4f19f81db322a90 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/fullscreen/ChromeFullscreenManager.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/fullscreen/ChromeFullscreenManager.java

@@ -33,6 +33,7 @@ import org.chromium.base.VisibleForTesting;

import org.chromium.chrome.browser.Tab;

import org.chromium.chrome.browser.fullscreen.FullscreenHtmlApiHandler.FullscreenHtmlApiDelegate;

import org.chromium.chrome.browser.tabmodel.TabModelSelector;

+import org.chromium.content.browser.ContentVideoView;

import org.chromium.content.browser.ContentViewCore;

import java.util.ArrayList;

@@ -229,7 +230,12 @@ public class ChromeFullscreenManager

@Override

public void onWindowFocusChanged(Activity activity, boolean hasFocus) {

- if (mActivity == activity) onWindowFocusChanged(hasFocus);

+ if (mActivity != activity) return;

+ onWindowFocusChanged(hasFocus);

+ ContentVideoView videoView = ContentVideoView.getContentVideoView();

+ if (videoView != null) {

+ videoView.onFullscreenWindowFocused();

+ }

}

@Override