Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 836053002: Added 128px icon size for bookmarked apps. (Closed)

Created:
5 years, 11 months ago by mitchellj
Modified:
5 years, 11 months ago
Reviewers:
benwells
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added 128px icon size for bookmarked apps. This icon size is needed for Mac. Now is consistent with icon sizes for packaged apps. BUG=445039 Committed: https://crrev.com/db9fdea11098e5c0dc751274481e82d9485d01e9 Cr-Commit-Position: refs/heads/master@{#310176}

Patch Set 1 #

Patch Set 2 : Updated ExtensionManagementApiTest for new icons #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M chrome/browser/extensions/bookmark_app_helper.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/management/test/generateAppForLink.js View 1 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
mitchellj
Ben, could you please review as owner? Thanks.
5 years, 11 months ago (2015-01-06 01:34:49 UTC) #2
benwells
lgtm
5 years, 11 months ago (2015-01-06 01:48:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/836053002/1
5 years, 11 months ago (2015-01-06 01:52:08 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_triggered_tests/builds/96337)
5 years, 11 months ago (2015-01-06 02:13:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/836053002/1
5 years, 11 months ago (2015-01-06 05:20:47 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/19665)
5 years, 11 months ago (2015-01-06 06:21:11 UTC) #11
mitchellj
Hi Ben, I didn't realise I also had to update the tests since we're generating ...
5 years, 11 months ago (2015-01-06 22:47:06 UTC) #12
benwells
lgtm
5 years, 11 months ago (2015-01-06 22:51:01 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/836053002/20001
5 years, 11 months ago (2015-01-06 22:51:45 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-06 23:54:55 UTC) #16
commit-bot: I haz the power
5 years, 11 months ago (2015-01-06 23:55:45 UTC) #17
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/db9fdea11098e5c0dc751274481e82d9485d01e9
Cr-Commit-Position: refs/heads/master@{#310176}

Powered by Google App Engine
This is Rietveld 408576698