Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Unified Diff: chrome/test/data/extensions/api_test/management/test/generateAppForLink.js

Issue 836053002: Added 128px icon size for bookmarked apps. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated ExtensionManagementApiTest for new icons Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/bookmark_app_helper.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/extensions/api_test/management/test/generateAppForLink.js
diff --git a/chrome/test/data/extensions/api_test/management/test/generateAppForLink.js b/chrome/test/data/extensions/api_test/management/test/generateAppForLink.js
index c7eba3b512f34f598edb7329aa94cd90b7cb1301..1135898348101576ebb475bcc4e44612e0ba241b 100644
--- a/chrome/test/data/extensions/api_test/management/test/generateAppForLink.js
+++ b/chrome/test/data/extensions/api_test/management/test/generateAppForLink.js
@@ -43,11 +43,13 @@ var tests = [
assertEq(title, data.name);
// There is no favicon in the test browser, so only 4 icons will
// be created.
- assertEq(4, data.icons.length);
+ assertEq(6, data.icons.length);
assertEq(32, data.icons[0].size);
assertEq(48, data.icons[1].size);
assertEq(64, data.icons[2].size);
assertEq(96, data.icons[3].size);
+ assertEq(128, data.icons[4].size);
+ assertEq(256, data.icons[5].size);
chrome.management.getAll(callback(function(items) {
assertTrue(getItemNamed(items, title) != null);
@@ -61,11 +63,13 @@ var tests = [
url, title, null, function(data) {
assertEq(url, data.appLaunchUrl);
assertEq(title, data.name);
- assertEq(4, data.icons.length);
+ assertEq(6, data.icons.length);
assertEq(32, data.icons[0].size);
assertEq(48, data.icons[1].size);
assertEq(64, data.icons[2].size);
assertEq(96, data.icons[3].size);
+ assertEq(128, data.icons[4].size);
+ assertEq(256, data.icons[5].size);
chrome.management.getAll(callback(function(items) {
assertTrue(getItemNamed(items, title) != null);
« no previous file with comments | « chrome/browser/extensions/bookmark_app_helper.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698