Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 836033005: AbortOptimization, RetryOptimization preserve first bailout reason (Closed)

Created:
5 years, 11 months ago by wingo
Modified:
5 years, 11 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

AbortOptimization, RetryOptimization preserve first bailout reason The current logic appears to have been introduced in https://codereview.chromium.org/596783002. R=yangguo@chromium.org BUG= Committed: https://crrev.com/79a8caec540ad5b8504aa6e387ccf07fb7a75ec1 Cr-Commit-Position: refs/heads/master@{#26043}

Patch Set 1 #

Patch Set 2 : Init bailout_reason_ to kNoReason, not kUnknown #

Total comments: 1

Patch Set 3 : Remove unused kUnknown bailout reason #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M src/bailout-reason.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler.h View 1 chunk +5 lines, -2 lines 0 comments Download
M src/compiler.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
wingo
Yang, does this look right to you? I get confused when looking at the pipeline ...
5 years, 11 months ago (2015-01-12 17:48:03 UTC) #1
wingo
https://codereview.chromium.org/836033005/diff/20001/src/compiler.h File src/compiler.h (left): https://codereview.chromium.org/836033005/diff/20001/src/compiler.h#oldcode333 src/compiler.h:333: if (bailout_reason_ != kNoReason) bailout_reason_ = reason; Because bailout_reason_ ...
5 years, 11 months ago (2015-01-12 18:06:50 UTC) #2
Yang
On 2015/01/12 18:06:50, wingo wrote: > https://codereview.chromium.org/836033005/diff/20001/src/compiler.h > File src/compiler.h (left): > > https://codereview.chromium.org/836033005/diff/20001/src/compiler.h#oldcode333 > ...
5 years, 11 months ago (2015-01-13 09:49:18 UTC) #3
wingo
Committed patchset #3 (id:40001) manually as 79a8caec540ad5b8504aa6e387ccf07fb7a75ec1 (presubmit successful).
5 years, 11 months ago (2015-01-13 14:37:18 UTC) #4
commit-bot: I haz the power
5 years, 11 months ago (2015-01-13 14:37:22 UTC) #5
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/79a8caec540ad5b8504aa6e387ccf07fb7a75ec1
Cr-Commit-Position: refs/heads/master@{#26043}

Powered by Google App Engine
This is Rietveld 408576698