Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 596783002: Refactor bailout reasons and disable optimization in more cases. (Closed)

Created:
6 years, 3 months ago by Yang
Modified:
6 years, 3 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Refactor bailout reasons and disable optimization in more cases. R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24161

Patch Set 1 #

Total comments: 2

Patch Set 2 : remove bogus assertion #

Unified diffs Side-by-side diffs Delta from patch set Stats (+534 lines, -596 lines) Patch
M BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M src/arm/lithium-arm.h View 3 chunks +2 lines, -30 lines 0 comments Download
M src/arm/lithium-arm.cc View 2 chunks +1 line, -7 lines 0 comments Download
M src/arm/macro-assembler-arm.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/arm64/lithium-arm64.h View 3 chunks +2 lines, -31 lines 0 comments Download
M src/arm64/lithium-arm64.cc View 2 chunks +1 line, -7 lines 0 comments Download
M src/arm64/macro-assembler-arm64.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/ast.h View 1 chunk +1 line, -0 lines 0 comments Download
A src/bailout-reason.h View 1 chunk +339 lines, -0 lines 0 comments Download
A src/bailout-reason.cc View 1 chunk +20 lines, -0 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler.h View 1 6 chunks +20 lines, -17 lines 0 comments Download
M src/compiler.cc View 14 chunks +60 lines, -71 lines 0 comments Download
M src/compiler/pipeline.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/hydrogen.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/hydrogen.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M src/ia32/lithium-ia32.h View 3 chunks +2 lines, -30 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 2 chunks +1 line, -7 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/lithium.h View 3 chunks +28 lines, -2 lines 0 comments Download
M src/lithium.cc View 4 chunks +15 lines, -2 lines 0 comments Download
M src/lithium-codegen.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/lithium-codegen.cc View 1 chunk +9 lines, -3 lines 0 comments Download
M src/log.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects.h View 2 chunks +1 line, -329 lines 0 comments Download
M src/objects.cc View 3 chunks +2 lines, -14 lines 0 comments Download
M src/optimizing-compiler-thread.cc View 2 chunks +6 lines, -1 line 0 comments Download
M src/parser.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/preparser.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/x64/lithium-x64.h View 3 chunks +2 lines, -30 lines 0 comments Download
M src/x64/lithium-x64.cc View 2 chunks +1 line, -7 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Yang
6 years, 3 months ago (2014-09-23 13:24:27 UTC) #1
Jakob Kummerow
lgtm https://codereview.chromium.org/596783002/diff/1/src/lithium.cc File src/lithium.cc (right): https://codereview.chromium.org/596783002/diff/1/src/lithium.cc#newcode7 src/lithium.cc:7: #include "src/bailout-reason.h" This shouldn't be necessary as lithium.h ...
6 years, 3 months ago (2014-09-23 16:21:00 UTC) #2
Sven Panne
https://codereview.chromium.org/596783002/diff/1/src/lithium.cc File src/lithium.cc (right): https://codereview.chromium.org/596783002/diff/1/src/lithium.cc#newcode7 src/lithium.cc:7: #include "src/bailout-reason.h" On 2014/09/23 16:21:00, Jakob wrote: > This ...
6 years, 3 months ago (2014-09-24 06:00:19 UTC) #4
Sven Panne
On 2014/09/24 06:00:19, Sven Panne wrote: > https://codereview.chromium.org/596783002/diff/1/src/lithium.cc > File src/lithium.cc (right): > > https://codereview.chromium.org/596783002/diff/1/src/lithium.cc#newcode7 ...
6 years, 3 months ago (2014-09-24 06:52:47 UTC) #5
Yang
6 years, 3 months ago (2014-09-24 07:09:01 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 24161 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698