Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 836023006: Fix broken iOS skia test and make sure it is compiled (Closed)

Created:
5 years, 11 months ago by noyau (Ping after 24h)
Modified:
5 years, 11 months ago
Reviewers:
Nico
CC:
chromium-reviews, sdefresne
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix broken iOS skia test and make sure it is compiled. The include was broken by https://codereview.chromium.org/832053004 and has gone completely unnoticed as the tests were not build on iOS. This CL fixes the test and adds skia_unittest to the list of targets build on iOS. BUG=447659 Committed: https://crrev.com/2866310ac0eee3bfe698b72a4642c8ebf1fab107 Cr-Commit-Position: refs/heads/master@{#312177}

Patch Set 1 #

Patch Set 2 : Compile the skia tests on iOS. #

Patch Set 3 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M build/all.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M skia/ext/skia_utils_ios_unittest.mm View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
noyau (Ping after 24h)
To thakis for review (you are the only owner of both build/ and skia/)
5 years, 11 months ago (2015-01-14 17:44:15 UTC) #3
noyau (Ping after 24h)
On 2015/01/14 17:44:15, noyau wrote: > To thakis for review (you are the only owner ...
5 years, 11 months ago (2015-01-19 10:07:53 UTC) #4
Nico
lgtm Sorry, I have no idea why I missed this.
5 years, 11 months ago (2015-01-19 18:08:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/836023006/40001
5 years, 11 months ago (2015-01-20 09:15:25 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/50436) ios_rel_device_ng on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ng/builds/2407) ios_rel_device_ninja_ng ...
5 years, 11 months ago (2015-01-20 09:18:09 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/836023006/60001
5 years, 11 months ago (2015-01-20 09:42:34 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:60001)
5 years, 11 months ago (2015-01-20 10:53:01 UTC) #12
commit-bot: I haz the power
5 years, 11 months ago (2015-01-20 10:53:51 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2866310ac0eee3bfe698b72a4642c8ebf1fab107
Cr-Commit-Position: refs/heads/master@{#312177}

Powered by Google App Engine
This is Rietveld 408576698