Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 832053004: skia: Do not include a source file in another source file. (Closed)

Created:
5 years, 11 months ago by tfarina
Modified:
5 years, 11 months ago
Reviewers:
Nico
CC:
chromium-reviews, danakj, reed1, sky
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

skia: Do not include a source file in another source file. That can can a duplication of definition of symbols. This was exposed by https://chromium.googlesource.com/chromium/src/+/c87c3d2d949f9ba4f17627dc023b303c75b7635f in the Mac GN builder with errors like: duplicate symbol __ZN3gfx27SkMatrixToCGAffineTransformERK8SkMatrix in: obj/skia/ext/skia_unittests.skia_utils_mac_unittest.o obj/skia/ext/skia.skia_utils_mac.o (and more similar issues). Entries were found with the following command line: $ g grep include skia/ext | grep mm\" BUG=444058 TEST=unit_tests R=thakis@chromium.org Committed: https://crrev.com/786967e07357b26548fc1c21f131c331053ef6d5 Cr-Commit-Position: refs/heads/master@{#310427}

Patch Set 1 #

Patch Set 2 : imports missing #

Patch Set 3 : SkCanvas include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M skia/ext/skia_utils_ios_unittest.mm View 1 1 chunk +3 lines, -1 line 0 comments Download
M skia/ext/skia_utils_mac_unittest.mm View 1 2 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
tfarina
PTAL
5 years, 11 months ago (2015-01-07 19:57:18 UTC) #1
Nico
lgtm
5 years, 11 months ago (2015-01-07 23:42:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/832053004/40001
5 years, 11 months ago (2015-01-07 23:42:58 UTC) #4
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 11 months ago (2015-01-08 01:18:03 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2015-01-08 01:19:01 UTC) #6
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/786967e07357b26548fc1c21f131c331053ef6d5
Cr-Commit-Position: refs/heads/master@{#310427}

Powered by Google App Engine
This is Rietveld 408576698