Descriptionskia: Do not include a source file in another source file.
That can can a duplication of definition of symbols.
This was exposed by
https://chromium.googlesource.com/chromium/src/+/c87c3d2d949f9ba4f17627dc023b303c75b7635f
in the Mac GN builder with errors like:
duplicate symbol __ZN3gfx27SkMatrixToCGAffineTransformERK8SkMatrix in:
obj/skia/ext/skia_unittests.skia_utils_mac_unittest.o
obj/skia/ext/skia.skia_utils_mac.o
(and more similar issues).
Entries were found with the following command line:
$ g grep include skia/ext | grep mm\"
BUG=444058
TEST=unit_tests
R=thakis@chromium.org
Committed: https://crrev.com/786967e07357b26548fc1c21f131c331053ef6d5
Cr-Commit-Position: refs/heads/master@{#310427}
Patch Set 1 #Patch Set 2 : imports missing #Patch Set 3 : SkCanvas include #
Messages
Total messages: 6 (1 generated)
|