chrome/browser/ui/webui/favicon_source.cc - Issue 835903005: [Favicon] Add new fallback icon rendering flow.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/favicon_source.cc

Issue 835903005: [Favicon] Add new fallback icon rendering flow. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Adding new host chrome://fallback-icon. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/favicon_source.cc

diff --git a/chrome/browser/ui/webui/favicon_source.cc b/chrome/browser/ui/webui/favicon_source.cc

index c7977999300299d78e100628ef983d61a07ccc8d..badb80a7e671498b31719ebaab8b3294a9479432 100644

--- a/chrome/browser/ui/webui/favicon_source.cc

+++ b/chrome/browser/ui/webui/favicon_source.cc

@@ -85,7 +85,7 @@ void FaviconSource::StartDataRequest(

if (parsed.is_icon_url) {

// TODO(michaelbai): Change GetRawFavicon to support combination of

// IconType.

- favicon_service->GetRawFavicon(

+ favicon_service->GetRawFavicon(

pkotwicz 2015/01/21 19:44:15 Can you move this change to a separate CL

huangs 2015/01/22 01:13:27 Done.

url,

favicon_base::FAVICON,

desired_size_in_pixel,