[Favicon] Add new fallback icon rendering flow.

chrome/browser/ui/webui/favicon_source.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/favicon_source.h"
 
 #include <cmath>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 67 matching lines @@
     return;
   }
 
   GURL url(parsed.url);
   int desired_size_in_pixel =
       std::ceil(parsed.size_in_dip * parsed.device_scale_factor);
 
   if (parsed.is_icon_url) {
     // TODO(michaelbai): Change GetRawFavicon to support combination of
     // IconType.
-   favicon_service->GetRawFavicon(
+    favicon_service->GetRawFavicon(

[pkotwicz, 2015/01/21 19:44:15]

Can you move this change to a separate CL

[huangs, 2015/01/22 01:13:27]

Done.

         url,
         favicon_base::FAVICON,
         desired_size_in_pixel,
         base::Bind(
             &FaviconSource::OnFaviconDataAvailable,
             base::Unretained(this),
             IconRequest(
                 callback, url, parsed.size_in_dip, parsed.device_scale_factor)),
         &cancelable_task_tracker_);
   } else {
@@ skipping 99 matching lines @@
     ui::ScaleFactor resource_scale_factor =
         ui::GetSupportedScaleFactor(icon_request.device_scale_factor);
     default_favicon =
         ResourceBundle::GetSharedInstance().LoadDataResourceBytesForScale(
             resource_id, resource_scale_factor);
     default_favicons_[favicon_index] = default_favicon;
   }
 
   icon_request.callback.Run(default_favicon);
 }