chrome/browser/favicon/favicon_service.cc - Issue 835903005: [Favicon] Add new fallback icon rendering flow.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/favicon/favicon_service.cc

Issue 835903005: [Favicon] Add new fallback icon rendering flow. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Adding new host chrome://fallback-icon. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/favicon/favicon_service.cc

diff --git a/chrome/browser/favicon/favicon_service.cc b/chrome/browser/favicon/favicon_service.cc

index 064151e925a10491667a4d449234b26602522807..207703c7242bdc8886df3f8052d82d7671017ae1 100644

--- a/chrome/browser/favicon/favicon_service.cc

+++ b/chrome/browser/favicon/favicon_service.cc

@@ -14,7 +14,6 @@

#include "chrome/browser/ui/webui/chrome_web_ui_controller_factory.h"

#include "chrome/common/importer/imported_favicon_usage.h"

#include "chrome/common/url_constants.h"

-#include "components/favicon_base/favicon_types.h"

#include "components/favicon_base/favicon_util.h"

#include "components/favicon_base/select_favicon_frames.h"

#include "extensions/common/constants.h"

@@ -22,6 +21,7 @@

#include "ui/gfx/codec/png_codec.h"

#include "ui/gfx/favicon_size.h"

#include "ui/gfx/image/image_skia.h"

+#include "url/gurl.h"

pkotwicz 2015/01/21 19:44:14 Thank you for making this change. However, can you

huangs 2015/01/22 01:13:27 Done, including putting back the removal of redund

using base::Bind;