[Favicon] Minor code cleanup.

[Favicon] Minor code cleanup.

TBR=jam

Committed: https://crrev.com/5f6eca4c8a501aecf685c1c7a8c4bfae66e99b72
Cr-Commit-Position: refs/heads/master@{#313301}

[huangs, 2015-01-26 21:24:34]

huangs@chromium.org changed reviewers:
+ pkotwicz@chromium.org

[huangs, 2015-01-26 21:24:35]

There should be no changes in functionality, except for extra sanity DCHECK().

[pkotwicz, 2015-01-26 22:27:19]

LGTM with comment

https://codereview.chromium.org/861333002/diff/20001/chrome/common/favicon/fa...
File chrome/common/favicon/favicon_url_parser.cc (right):

https://codereview.chromium.org/861333002/diff/20001/chrome/common/favicon/fa...
chrome/common/favicon/favicon_url_parser.cc:38: DCHECK(parsed);
I think the DCHECK() is not useful. If |parsed| is NULL, Line 39 will crash even
without a DCHECK()

[huangs, 2015-01-26 23:00:43]

Thanks! Submitting.

https://codereview.chromium.org/861333002/diff/20001/chrome/common/favicon/fa...
File chrome/common/favicon/favicon_url_parser.cc (right):

https://codereview.chromium.org/861333002/diff/20001/chrome/common/favicon/fa...
chrome/common/favicon/favicon_url_parser.cc:38: DCHECK(parsed);
It's a controlled-crash vs. uncontrolled-crash issue, which is the raison d'etre
of DCHECK().  I don't feel too strongly to push this though, so removed.

[huangs, 2015-01-26 23:00:53]

The CQ bit was checked by huangs@chromium.org

[commit-bot: I haz the power, 2015-01-26 23:01:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/861333002/40001

[commit-bot: I haz the power, 2015-01-26 23:08:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-26 23:08:34]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[huangs, 2015-01-27 16:47:36]

huangs@chromium.org changed reviewers:
+ jam@chromium.org

[huangs, 2015-01-27 16:48:11]

OWNER review to jam@, as TBR (minor code cleanup without feature change).

[huangs, 2015-01-27 16:48:15]

The CQ bit was checked by huangs@chromium.org

[commit-bot: I haz the power, 2015-01-27 16:48:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/861333002/40001

[commit-bot: I haz the power, 2015-01-27 16:48:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-27 16:48:52]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[huangs, 2015-01-27 17:06:09]

The CQ bit was checked by huangs@chromium.org

[commit-bot: I haz the power, 2015-01-27 17:06:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/861333002/40001

[commit-bot: I haz the power, 2015-01-27 17:47:53]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-01-27 17:49:28]

Patchset 3 (id:??) landed as
https://crrev.com/5f6eca4c8a501aecf685c1c7a8c4bfae66e99b72
Cr-Commit-Position: refs/heads/master@{#313301}