debugger: Update inspector view data consistently while paused

debugger: Update inspector view data consistently while paused

Make all fields of inspector view (details tab, clipstack tab, geometry
view) update the correct info when user selects a draw command. Also
update the info regardless if the painting is paused or not.

Current clip and matrix will not update consistently even after this
patch, as they depend on stateful debug canvas draw (may be fixed
later).

Committed: https://skia.googlesource.com/skia/+/0cfeaf3ac1e7edcf3b618c9f33f4b4bc30321324

[Kimmo Kinnunen, 2015-01-05 12:07:01]

kkinnunen@nvidia.com changed reviewers:
+ robertphillips@google.com

[robertphillips, 2015-01-05 19:14:09]

lgtm + nits

https://codereview.chromium.org/835903002/diff/20001/debugger/QT/SkDebuggerGU...
File debugger/QT/SkDebuggerGUI.cpp (right):

https://codereview.chromium.org/835903002/diff/20001/debugger/QT/SkDebuggerGU...
debugger/QT/SkDebuggerGUI.cpp:419: 
Don't we no longer need this "currentRow != -1" test?

https://codereview.chromium.org/835903002/diff/20001/debugger/QT/SkDrawComman...
File debugger/QT/SkDrawCommandGeometryWidget.cpp (right):

https://codereview.chromium.org/835903002/diff/20001/debugger/QT/SkDrawComman...
debugger/QT/SkDrawCommandGeometryWidget.cpp:70: fCommandIndex = commandIndex;
this-> ?

[Kimmo Kinnunen, 2015-01-07 07:33:48]

https://codereview.chromium.org/835903002/diff/20001/debugger/QT/SkDebuggerGU...
File debugger/QT/SkDebuggerGUI.cpp (right):

https://codereview.chromium.org/835903002/diff/20001/debugger/QT/SkDebuggerGU...
debugger/QT/SkDebuggerGUI.cpp:419: 
On 2015/01/05 19:14:09, robertphillips wrote:
> Don't we no longer need this "currentRow != -1" test?

Done. (Sorry, that was a rebase error, too many patches for my skills :( )

https://codereview.chromium.org/835903002/diff/20001/debugger/QT/SkDrawComman...
File debugger/QT/SkDrawCommandGeometryWidget.cpp (right):

https://codereview.chromium.org/835903002/diff/20001/debugger/QT/SkDrawComman...
debugger/QT/SkDrawCommandGeometryWidget.cpp:70: fCommandIndex = commandIndex;
On 2015/01/05 19:14:09, robertphillips wrote:
> this-> ?

Done.

[Kimmo Kinnunen, 2015-01-07 07:34:58]

The CQ bit was checked by kkinnunen@nvidia.com

[commit-bot: I haz the power, 2015-01-07 07:35:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/835903002/40001

[commit-bot: I haz the power, 2015-01-07 15:33:50]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/0cfeaf3ac1e7edcf3b618c9f33f4b4bc30321324