debugger: Update inspector view data consistently while paused

debugger/QT/SkDrawCommandGeometryWidget.cpp

 
 /*
  * Copyright 2014 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include <QtGui>
 
 #include "SkDebugger.h"
 #include "SkDrawCommandGeometryWidget.h"
 
 SkDrawCommandGeometryWidget::SkDrawCommandGeometryWidget(SkDebugger *debugger)
     : QFrame()
-    , fDebugger(debugger) {
+    , fDebugger(debugger)
+    , fCommandIndex(-1) {
     this->setStyleSheet("QFrame {background-color: black; border: 1px solid #cccccc;}");
 }
 
 void SkDrawCommandGeometryWidget::resizeEvent(QResizeEvent* event) {
     this->QFrame::resizeEvent(event);
     QRect r = this->contentsRect();
     int dim = std::min(r.width(), r.height());
     if (dim == 0) {
         fSurface.reset(NULL);
     } else {
@@ skipping 31 matching lines @@
         resultRect.moveCenter(this->contentsRect().center());
 
         QImage image(reinterpret_cast<const uchar*>(pixels),
                      info.width(),
                      info.height(),
                      QImage::Format_ARGB32_Premultiplied);
         painter.drawImage(resultRect, image);
     }
 }
 
+void SkDrawCommandGeometryWidget::setDrawCommandIndex(int commandIndex) {
+    fCommandIndex = commandIndex;

[robertphillips, 2015/01/05 19:14:09]

this-> ?

[Kimmo Kinnunen, 2015/01/07 07:33:48]

Done.

+    updateImage();
+}
+
 void SkDrawCommandGeometryWidget::updateImage() {
     if (!fSurface) {
         return;
     }
 
     bool didRender = false;
     const SkTDArray<SkDrawCommand*>& commands = fDebugger->getDrawCommands();
-    if (0 != commands.count()) {
-        SkDrawCommand* command = commands[fDebugger->index()];
+    if (0 != commands.count() && fCommandIndex >= 0) {
+        SkASSERT(commands.count() > fCommandIndex);
+        SkDrawCommand* command = commands[fCommandIndex];
         didRender = command->render(fSurface->getCanvas());
     }
 
     if (!didRender) {
         fSurface->getCanvas()->clear(SK_ColorTRANSPARENT);
     }
 
     fSurface->getCanvas()->flush();
     update();
 }