Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 835873004: IPC: Generalize FileDescriptorSet to MessageAttachmentSet (Closed)

Created:
5 years, 11 months ago by Hajime Morrita
Modified:
5 years, 11 months ago
Reviewers:
agl, viettrungluu
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

IPC: Generalize FileDescriptorSet to MessageAttachmentSet This is a preparation for crbug.com/448190, where we're going to allow Mojo MessagePipe being sent over Chrome IPC. The plan is that we'll extend existing FileDescriptorSet to carry both platform handles and Mojo's MessagePipes, then let ChannelMojo take care of these handles. As the first step, this change renames FileDescriptorSet to MessageAttachmentSet and moves it out from the OS_POSIX guard. Although this change doesn't do anything significant, we'll generalize it to carry both platform files and mojo handles eventually. R=agl@chromium.org, viettrungluu@chromium.org BUG=448190 Committed: https://crrev.com/4b5c28e2f3e3400b5e91129704368845688d40fe Cr-Commit-Position: refs/heads/master@{#311546}

Patch Set 1 #

Patch Set 2 : Landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -617 lines) Patch
M ipc/BUILD.gn View 3 chunks +3 lines, -3 lines 0 comments Download
D ipc/file_descriptor_set_posix.h View 1 chunk +0 lines, -119 lines 0 comments Download
D ipc/file_descriptor_set_posix.cc View 1 chunk +0 lines, -162 lines 0 comments Download
D ipc/file_descriptor_set_posix_unittest.cc View 1 chunk +0 lines, -183 lines 0 comments Download
M ipc/ipc.gyp View 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M ipc/ipc_channel_nacl.cc View 5 chunks +8 lines, -9 lines 0 comments Download
M ipc/ipc_channel_posix.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ipc/ipc_channel_posix.cc View 9 chunks +15 lines, -17 lines 0 comments Download
M ipc/ipc_message.h View 2 chunks +9 lines, -12 lines 0 comments Download
M ipc/ipc_message.cc View 7 chunks +16 lines, -17 lines 0 comments Download
A + ipc/ipc_message_attachment_set.h View 7 chunks +29 lines, -20 lines 0 comments Download
A + ipc/ipc_message_attachment_set.cc View 1 8 chunks +41 lines, -26 lines 0 comments Download
A + ipc/ipc_message_attachment_set_posix_unittest.cc View 12 chunks +26 lines, -24 lines 0 comments Download
M ipc/ipc_message_utils.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M ipc/ipc_send_fds_test.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M ipc/mojo/ipc_channel_mojo.h View 1 chunk +4 lines, -3 lines 0 comments Download
M ipc/mojo/ipc_channel_mojo.cc View 4 chunks +6 lines, -9 lines 0 comments Download
M ipc/mojo/ipc_message_pipe_reader.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Hajime Morrita
5 years, 11 months ago (2015-01-14 18:49:22 UTC) #1
agl
lgtm
5 years, 11 months ago (2015-01-14 18:58:10 UTC) #2
Hajime Morrita
Thanks!
5 years, 11 months ago (2015-01-14 19:21:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/835873004/20001
5 years, 11 months ago (2015-01-14 19:22:42 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-14 21:17:47 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-14 21:18:46 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4b5c28e2f3e3400b5e91129704368845688d40fe
Cr-Commit-Position: refs/heads/master@{#311546}

Powered by Google App Engine
This is Rietveld 408576698