ipc/ipc_channel_posix.h - Issue 835873004: IPC: Generalize FileDescriptorSet to MessageAttachmentSet

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ipc/ipc_channel_posix.h

Issue 835873004: IPC: Generalize FileDescriptorSet to MessageAttachmentSet (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Landing Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ipc/ipc_channel_posix.h

diff --git a/ipc/ipc_channel_posix.h b/ipc/ipc_channel_posix.h

index 1cb76102c3905eba818929ed536a73f47f048111..a792afa39163dc2503145e0bf654dedab2fc1ac8 100644

--- a/ipc/ipc_channel_posix.h

+++ b/ipc/ipc_channel_posix.h

@@ -17,8 +17,8 @@

#include "base/files/scoped_file.h"

#include "base/message_loop/message_loop.h"

#include "base/process/process.h"

-#include "ipc/file_descriptor_set_posix.h"

#include "ipc/ipc_channel_reader.h"

+#include "ipc/ipc_message_attachment_set.h"

#if !defined(OS_MACOSX)

// On Linux, the seccomp sandbox makes it very expensive to call

@@ -178,7 +178,7 @@ class IPC_EXPORT ChannelPosix : public Channel,

// message has no payload and a full complement of descriptors.

static const size_t kMaxReadFDs =

(Channel::kReadBufferSize / sizeof(IPC::Message::Header)) *

- FileDescriptorSet::kMaxDescriptorsPerMessage;

+ MessageAttachmentSet::kMaxDescriptorsPerMessage;

// Buffer size for file descriptors used for recvmsg. On Mac the CMSG macros

// don't seem to be constant so we have to pick a "large enough" value.

« no previous file with comments | « ipc/ipc_channel_nacl.cc ('k') | ipc/ipc_channel_posix.cc » ('j') | no next file with comments »