Show suggest apps dialog also in Download.

Show suggest apps dialog also in Download.

This CL also changes not to show suggest apps dialog for executable files.

BUG=445087, 376494
TEST=out/Release/browser_tests --gtest_filter=FileManagerJsTest.FileTasks:FileManagerJsTest.TaskController

Committed: https://crrev.com/090a00e7ff8c5fb1edb2b54b37efc69bae9c4935
Cr-Commit-Position: refs/heads/master@{#312307}

[yawano, 2015-01-19 11:09:24]

yawano@chromium.org changed reviewers:
+ fukino@chromium.org

[yawano, 2015-01-19 11:09:24]

PTAL. Thank you!

[fukino, 2015-01-20 03:50:35]

Comments which is not about the code:
- Please add 376494 to BUG
- It's not common to use past form for the issue title. Maybe 'Changed to' is
not necessary?

[yawano, 2015-01-20 03:53:37]

On 2015/01/20 03:50:35, fukino wrote:
> Comments which is not about the code:
> - Please add 376494 to BUG
> - It's not common to use past form for the issue title. Maybe 'Changed to' is
> not necessary?

Updated the comment. Thank you!

[fukino, 2015-01-20 04:45:03]

https://codereview.chromium.org/835803003/diff/1/ui/file_manager/file_manager...
File ui/file_manager/file_manager/foreground/js/task_controller.js (right):

https://codereview.chromium.org/835803003/diff/1/ui/file_manager/file_manager...
ui/file_manager/file_manager/foreground/js/task_controller.js:244:
this.ui_.suggestAppsDialog.showByExtensionAndMime(
showByFilename() is not in use now? If so, please remove the method. Maybe
SUGGEST_DIALOG_MESSAGE_FOR_EXECUTABLE can be removed, too.

[yawano, 2015-01-20 08:48:24]

Thank you for the review! PTAL.

https://codereview.chromium.org/835803003/diff/1/ui/file_manager/file_manager...
File ui/file_manager/file_manager/foreground/js/task_controller.js (right):

https://codereview.chromium.org/835803003/diff/1/ui/file_manager/file_manager...
ui/file_manager/file_manager/foreground/js/task_controller.js:244:
this.ui_.suggestAppsDialog.showByExtensionAndMime(
On 2015/01/20 04:45:03, fukino wrote:
> showByFilename() is not in use now? If so, please remove the method. Maybe
> SUGGEST_DIALOG_MESSAGE_FOR_EXECUTABLE can be removed, too.

showByFilename is removed with the patch set 1. Removed unused
SUGGEST_DIALOG_MESSAGE_FOR_EXECUTABLE with the new patch set.

[fukino, 2015-01-20 08:59:27]

On 2015/01/20 08:48:24, yawano wrote:
> Thank you for the review! PTAL.
> 
>
https://codereview.chromium.org/835803003/diff/1/ui/file_manager/file_manager...
> File ui/file_manager/file_manager/foreground/js/task_controller.js (right):
> 
>
https://codereview.chromium.org/835803003/diff/1/ui/file_manager/file_manager...
> ui/file_manager/file_manager/foreground/js/task_controller.js:244:
> this.ui_.suggestAppsDialog.showByExtensionAndMime(
> On 2015/01/20 04:45:03, fukino wrote:
> > showByFilename() is not in use now? If so, please remove the method. Maybe
> > SUGGEST_DIALOG_MESSAGE_FOR_EXECUTABLE can be removed, too.
> 
> showByFilename is removed with the patch set 1. Removed unused
> SUGGEST_DIALOG_MESSAGE_FOR_EXECUTABLE with the new patch set.

Thanks! lgtm.

[yawano, 2015-01-20 09:03:18]

On 2015/01/20 08:59:27, fukino wrote:
> On 2015/01/20 08:48:24, yawano wrote:
> > Thank you for the review! PTAL.
> > 
> >
>
https://codereview.chromium.org/835803003/diff/1/ui/file_manager/file_manager...
> > File ui/file_manager/file_manager/foreground/js/task_controller.js (right):
> > 
> >
>
https://codereview.chromium.org/835803003/diff/1/ui/file_manager/file_manager...
> > ui/file_manager/file_manager/foreground/js/task_controller.js:244:
> > this.ui_.suggestAppsDialog.showByExtensionAndMime(
> > On 2015/01/20 04:45:03, fukino wrote:
> > > showByFilename() is not in use now? If so, please remove the method. Maybe
> > > SUGGEST_DIALOG_MESSAGE_FOR_EXECUTABLE can be removed, too.
> > 
> > showByFilename is removed with the patch set 1. Removed unused
> > SUGGEST_DIALOG_MESSAGE_FOR_EXECUTABLE with the new patch set.
> 
> Thanks! lgtm.

Thank you!

[yawano, 2015-01-20 09:03:25]

The CQ bit was checked by yawano@chromium.org

[commit-bot: I haz the power, 2015-01-20 09:04:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/835803003/20001

[commit-bot: I haz the power, 2015-01-20 09:11:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-20 09:11:13]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[yawano, 2015-01-20 09:21:10]

yawano@chromium.org changed reviewers:
+ yoshiki@chromium.org

[yawano, 2015-01-20 09:21:10]

@yoshiki: PTAL for private_api_strings.cc. Thank you!

[yoshiki, 2015-01-20 10:25:45]

lgtm

[yawano, 2015-01-20 10:31:34]

On 2015/01/20 10:25:45, yoshiki wrote:
> lgtm

Thank you!

[yawano, 2015-01-20 10:31:45]

The CQ bit was checked by yawano@chromium.org

[commit-bot: I haz the power, 2015-01-20 10:32:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/835803003/20001

[commit-bot: I haz the power, 2015-01-20 10:32:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-20 10:32:52]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[yawano, 2015-01-21 01:40:48]

The CQ bit was checked by yawano@chromium.org

[yawano, 2015-01-21 01:42:37]

The CQ bit was unchecked by yawano@chromium.org

[yawano, 2015-01-21 01:48:38]

The CQ bit was checked by yawano@chromium.org

[commit-bot: I haz the power, 2015-01-21 01:50:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/835803003/20001

[commit-bot: I haz the power, 2015-01-21 11:04:50]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-01-21 11:05:41]

Patchset 2 (id:??) landed as
https://crrev.com/090a00e7ff8c5fb1edb2b54b37efc69bae9c4935
Cr-Commit-Position: refs/heads/master@{#312307}

[Steve McKay, 2015-01-22 01:35:11]

smckay@chromium.org changed reviewers:
+ smckay@chromium.org

[Steve McKay, 2015-01-22 01:35:12]

https://codereview.chromium.org/835803003/diff/20001/ui/file_manager/file_man...
File ui/file_manager/file_manager/foreground/js/task_controller.js (right):

https://codereview.chromium.org/835803003/diff/20001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/task_controller.js:264:
chrome.fileManagerPrivate.getMimeType(entry.toURL(), resolve);
This is causing the closure compiler to choke.

##
/usr/local/google/home/smckay/srcs/chromium/src/ui/file_manager/file_manager/foreground/js/task_controller.js:264:
ERROR - Property getMimeType never defined on chrome.fileManagerPrivate
##         chrome.fileManagerPrivate.getMimeType(entry.toURL(), resolve);
##         ^

There's probably some extern file that needs to be updated with the
"getMimeType" method.